Fix three issues: init __what_to_create, honor resample_dt, and correct get_t_isco indexing#13
Merged
AnujKankani merged 3 commits intodevfrom Feb 20, 2026
Conversation
AnujKankani
added a commit
that referenced
this pull request
Mar 25, 2026
* updated joss paper * paper formatting * Fix three issues: init `__what_to_create`, honor `resample_dt`, and correct `get_t_isco` indexing (#13) * bump version [skip ci] * Fix get_t_isco time indexing after cropping * Add missing init and CCE resample_dt fixes * update trusted values post cce dt fix * update workflow [reset cache] * [reset cache] * change default dt * mismatch resample reliability increased * reduce tolerance * reduce tolerance for optimized Omega_0 mismatch * lower tolerance for Omega_0 as well * fix mismatch testing * fix file prefix
AnujKankani
added a commit
that referenced
this pull request
Mar 25, 2026
* updated joss paper * paper formatting * Fix three issues: init `__what_to_create`, honor `resample_dt`, and correct `get_t_isco` indexing (#13) * bump version [skip ci] * Fix get_t_isco time indexing after cropping * Add missing init and CCE resample_dt fixes * update trusted values post cce dt fix * update workflow [reset cache] * [reset cache] * change default dt * mismatch resample reliability increased * reduce tolerance * reduce tolerance for optimized Omega_0 mismatch * lower tolerance for Omega_0 as well * fix mismatch testing * fix file prefix * fix offline testing * update env variables in testing * test file prefix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
set_initial_timereferencedself.__what_to_createbefore it was initialized, which can raise anAttributeErrorif initial time is set prior to selecting what to create.resample_dtargument but did not apply it, causing callers to be ignored.get_t_iscocomputed a nearest-frequency index from a cropped frequency array but indexed the uncropped time array, producing incorrect ISCO time lookups.Description
self.__what_to_create = "Nothing"in theBOB.__init__constructor to ensure the attribute exists beforeset_initial_timeuses it.self.resample_dt = resample_dtat the start of the CCE initialization function so the passedresample_dtis honored for resampling.self.data.t[...]withfreq_data.t[...]inget_t_iscoso the time lookup matches the cropped frequency array used to compute the index.Testing
gwBOB/BOB_utils.pyto confirm the intended lines were modified, and those checks passed.pytest) was executed for these changes.Codex Task