Skip to content

Fix three issues: init __what_to_create, honor resample_dt, and correct get_t_isco indexing #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnujKankani merged 3 commits into from
Feb 20, 2026
Merged

Fix three issues: init __what_to_create, honor resample_dt, and correct get_t_isco indexing #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2e466b
bump version [skip ci]
AnujKankani Dec 26, 2025
07da8d8
Fix get_t_isco time indexing after cropping
AnujKankani Feb 20, 2026
1c6e0fb
Add missing init and CCE resample_dt fixes
AnujKankani Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion gwBOB/BOB_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ def __init__(self):
self.tp = 0

self.what_is_BOB_building="Nothing"
self.__what_to_create = "Nothing"
self.l = 2
self.m = 2
self.Phi_0 = 0
Expand Down Expand Up @@ -619,7 +620,7 @@ def get_t_isco(self):
float: Time of ISCO of the waveform
'''
freq_data = gen_utils.get_frequency(self.data).cropped(init=self.tp-100,end=self.tp+50)
t_isco = self.data.t[gen_utils.find_nearest_index(freq_data.y,self.Omega_ISCO*np.abs(self.m))]
t_isco = freq_data.t[gen_utils.find_nearest_index(freq_data.y,self.Omega_ISCO*np.abs(self.m))]
return t_isco - self.tp

def construct_BOB_finite_t0(self,N):
Expand Down Expand Up @@ -1124,6 +1125,8 @@ def initialize_with_cce_data(self,cce_id,l=2,m=2,perform_superrest_transformatio
import qnmfits #adding here so this code can be used without WSL for non-cce purposes
print("loading CCE id",cce_id)

self.resample_dt = resample_dt

if(provide_own_abd is None):
abd = qnmfits.cce.load(cce_id)
else:
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"

[project]
name = "gwBOB"
version = "1.0.1"
version = "1.0.2"
description = "A Backwards-One-Body Gravitational Waveform Package"
readme = { file = "README.md", content-type = "text/markdown" }
authors = [
Expand Down
Loading