fix(security): reject weak PASTE_AUTH_SECRET in production - #68
Merged
Conversation
Refuse empty, short, and documented placeholder secrets so unlock cookies cannot be forged on default Compose deploys. Require an explicit PASTE_AUTH_SECRET in docker-compose. Closes #65
Owner
Author
Code review summaryReviewed for security correctness (weak-secret rejection, Compose fail-fast, privacy of error messages). Verdict: No bug-severity findings. Suggestions only (docs comment polish, extra boundary tests) — non-blocking. CI |
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<16)PASTE_AUTH_SECRETvaluesCloses #65
Test plan
pnpm test(121 tests)pnpm lintpnpm typecheckpnpm buildcigreen