Conversation
This is a typo in all the existing docs.
|
Oh nice! This is a very welcome step 😄 do you have broader plans regarding Qt6 adoption in Asteroid or was that a one-off experiment ? And if so, is there any way we could help or support you with that ? |
|
I do want to get all of the AsteroidOS UI and apps running on top of Qt6 with Halium/libhybris yes, but we'll see how large this ends up being as yet another project I've decided to undertake for some reason 🤣 |
This comment was marked as outdated.
This comment was marked as outdated.
It's a POSIX sh script as indicated by its shebang.
src/controls/CMakeLists.txt already makes use of the following: https://cmake.org/cmake/help/latest/manual/cmake-generator-expressions.7.html#list-transformations
To fix the following observed build warning:
src/app/asteroidapp.cpp:80:13: warning: ignoring return value of function declared with 'nodiscard' attribute [-Wunused-result]
80 | translator->load(QLocale(), appName(), ".", "/usr/share/translations", ".qm");
| ^~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Re-use the already existing listing of controls used for documentation generation as well. WIP because this will be replaced by qt_add_qml_module()
Fixes runtime warnings such as:
qt.qml.context: qrc:/org/asteroid/controls/qml/BorderGestureArea.qml:160:5 Parameter "mouse" is not declared. Injection of parameters into signal handlers is deprecated. Use JavaScript functions with formal parameters instead.
As an alternative the following also would work:
function onPressed(mouse) { ... }
This doesn't work on Chimera Linux which uses the FreeBSD grep(1); adds a new build-time dependency on xmllint which I'm not sure how to feel about yet.
It's worth revisiting if this makes sense to keep as a dependency with some repeatable benchmarks where a quantifiable difference may or may not be observed when running this on a watch. If this is to be removed cmake/FindMapplauncherd_qt*.cmake additionally should also be gone.
Let's adopt QTP0001 already and move all per-application resources under qrc:/qt/qml/AsteroidApp/
This one (for now at least) retains the manually written plugin instead
of generating one since it also changes the default font instead of just
calling qmlRegisterType for each C++ QML component:
QGuiApplication::setFont(QFont("Noto Sans"));
If another way to accomplish the same task globally for anything using
org.asteroid.controls is found the same as one commit above for
org.asteroid.utils can also be done here and controls_plugin.* can be
done away with.
|
So this means there will be AsteroidOS GUI running on top of Chimera Linux? Sweet! I could build random stuff without risking my watch then. |
|
Hey @JamiKettunen, I took several of your commits and put them in separate PR's which got merged. I also made qml-asteroid compile with both Qt5 and Qt6 in #83 which also got merged 🎉 I'm not sure if there is something left in this PR you still want to have, if so please rebase this PR and preferably submit the changes separately from each other. |
4 participants
Builds as tested on Qt 6.8.0. Current status:
asteroid-calculatorwith patches runs!My AsteroidOS package integration work for Chimera Linux which this PR is a part of along with all other patches can be found at https://github.com/JamiKettunen/cports/commits/hybris/; I'll likely update this description when I have more stuff of interest to share..