enable build-params evaluation of for-expressions in .bicepparam#18949
Open
polatengin wants to merge 6 commits intomainfrom
Conversation
…ation with expression variables
Contributor
|
Test this change out locally with the following install scripts (Action run 23675574785) VSCode
Azure CLI
|
Contributor
|
FYI the playground test has been fixed via this PR. You can merge/rebase from main. |
…y-building-inputs-in-bicepparam-files-to-reduce-duplication
…y-building-inputs-in-bicepparam-files-to-reduce-duplication
Contributor
|
fyi I made some recent changes to |
…pbcp338-when-dynamically-building-inputs-in-bicepparam-files-to-reduce-duplication # Conflicts: # src/Bicep.Core/Emit/ParameterAssignmentEvaluator.cs
Member
Author
|
@levimatheri , I merged the changes on Please review the PR, it's ready 😄 |
levimatheri
reviewed
Mar 28, 2026
| /// Rewrites the external input function calls to use the externalInputs function with the index of the external input. | ||
| /// e.g. externalInput('sys.cli', 'foo') becomes externalInputs('0') | ||
| /// </summary> | ||
| private class ExternalInputExpressionRewriter : ExpressionRewriteVisitor |
Contributor
There was a problem hiding this comment.
This class isn't used anymore, we should remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14722
Description
build-paramsnow evaluatesfor-expressionsin parameter assignments by expanding them at compile time, avoidingvariables()runtime evaluation errors.I also added coverage for this scenario in both CLI integration tests and core unit tests.
Checklist
Microsoft Reviewers: Open in CodeFlow