Fix actionlint false failure by correctly excluding vendored dotnet-install.sh from ShellCheck#840
Conversation
|
@Bryan-Roe Unfortunately, I hit an error while trying to use the custom Copilot setup steps configured for this repository and had to close this PR. The error I am seeing is: Once you or someone with the necessary access fixes the problem, please unassign and then reassign issue #0 to me and I'll retry. Thanks! |
dotnet-install.sh from ShellCheck
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @Bryan-Roe, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
@Bryan-Roe Thanks for sending me some feedback. Unfortunately, I hit an error while trying to use the custom Copilot setup steps configured for this repository. The error I am seeing is: Once you or someone with the necessary access fixes the problem, please let me know in a comment and I'll try again. Thanks! |
There was a problem hiding this comment.
Pull request overview
Updates Workflow Lint to exclude the vendored .NET installer from ShellCheck and adds regression coverage.
Changes:
- Adjusts the ShellCheck exclusion path.
- Adds a unit test for the workflow configuration.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/actionlint.yml |
Updates ShellCheck ignore paths. |
tests/test_actionlint_workflow.py |
Verifies the exclusion configuration. |
| # Microsoft .NET installer) and generated agent-template directories. | ||
| ignore_paths: dotnet-install.sh my-agent-0b2avt | ||
| ignore_paths: >- | ||
| */dotnet-install.sh |
| ) | ||
|
|
||
| ignore_paths = shellcheck_step["with"]["ignore_paths"].split() | ||
| assert "*/dotnet-install.sh" in ignore_paths |
| ignore_paths: dotnet-install.sh my-agent-0b2avt | ||
| ignore_paths: >- | ||
| */dotnet-install.sh | ||
| my-agent-0b2avt |
The
Workflow Lintjob was failing inactionlintbecause ShellCheck scanned the vendored root./dotnet-install.shand reported SC2068 errors from third-party code. The configured ignore pattern did not match the actual scanned path format.Root cause
ignore_paths: dotnet-install.shin.github/workflows/actionlint.ymldid not reliably exclude./dotnet-install.shin theludeeus/action-shellcheckpath matching flow.Workflow hardening change
*/dotnet-install.shmy-agent-0b2avt(existing generated-path exclusion retained)Regression protection
tests/test_actionlint_workflow.pyto assert the actionlint ShellCheck step preserves the vendored-script exclusion pattern.