Skip to content

Fix actionlint false failure by correctly excluding vendored dotnet-install.sh from ShellCheck #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bryan-Roe merged 2 commits into from
Jul 11, 2026
+23 −1
Merged

Fix actionlint false failure by correctly excluding vendored dotnet-install.sh from ShellCheck #840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0ba8b7
Initial plan
Copilot Jul 11, 2026
468848a
Fix actionlint shellcheck ignore path for vendored dotnet script
Copilot Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/actionlint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ jobs:
version: ${{ env.SHELLCHECK_VERSION }}
# Exclude vendored third-party scripts (dotnet-install.sh is the
# Microsoft .NET installer) and generated agent-template directories.
ignore_paths: dotnet-install.sh my-agent-0b2avt
ignore_paths: >-
*/dotnet-install.sh
my-agent-0b2avt
# Only fail CI on error-severity findings; warnings in our own
# scripts are reported but do not block the build.
severity: error
Expand Down
20 changes: 20 additions & 0 deletions tests/test_actionlint_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
from __future__ import annotations

from pathlib import Path

import pytest
import yaml

pytestmark = pytest.mark.unit


def test_actionlint_shellcheck_ignores_vendored_dotnet_script() -> None:
workflow_path = Path(__file__).resolve().parents[1] / ".github" / "workflows" / "actionlint.yml"
workflow = yaml.safe_load(workflow_path.read_text(encoding="utf-8"))

shellcheck_step = next(
step for step in workflow["jobs"]["actionlint"]["steps"] if step.get("name") == "Setup ShellCheck (pinned)"
)

ignore_paths = shellcheck_step["with"]["ignore_paths"].split()
assert "*/dotnet-install.sh" in ignore_paths
Loading