Skip to content

Harden markdownlint target selection to skip generated root guides#849

Merged
Bryan-Roe merged 2 commits into
mainfrom
copilot/fix-markdownlint-job
Jul 11, 2026
Merged

Harden markdownlint target selection to skip generated root guides#849
Bryan-Roe merged 2 commits into
mainfrom
copilot/fix-markdownlint-job

Conversation

Copilot AI commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

The markdownlint Actions job was failing on generated docs under docs/root-guides/ with large volumes of MD060/MD007 violations. This change narrows markdown target selection so the workflow lints intended maintainable markdown sources only.

  • Workflow change: target filter hardening

    • Updated .github/workflows/markdown-quality.yml (Select markdown targets step).
    • Extended is_markdown_target() exclusion patterns to skip:
      • docs/root-guides/*
  • Contract test update

    • Updated tests/test_markdown_quality_workflow.py to assert the workflow script includes the docs/root-guides/* exclusion, preventing drift.
case "$file" in
  */node_modules/*|...|data_out/*|mount/*|docs/root-guides/*|*/CHANGELOG.md|CHANGELOG.md)
    return 1
    ;;
esac

Copilot AI review requested due to automatic review settings July 11, 2026 04:36

Copilot AI commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

@Bryan-Roe Unfortunately, I hit an error while trying to use the custom Copilot setup steps configured for this repository and had to close this PR. The error I am seeing is:

no `copilot-setup-steps` job found in your `copilot-setup-steps.yml` workflow file. Please ensure you have a single job named `copilot-setup-steps`. For more details, see https://gh.io/copilot/actions-setup-steps

Once you or someone with the necessary access fixes the problem, please unassign and then reassign issue #0 to me and I'll retry. Thanks!

Copilot AI removed the request for review from Copilot July 11, 2026 04:36
Copilot AI requested review from Copilot and removed request for Copilot July 11, 2026 04:38
Copilot AI changed the title [WIP] Fix failing GitHub Actions job markdownlint Harden markdownlint target selection to skip generated root guides Jul 11, 2026
Copilot AI requested a review from Bryan-Roe July 11, 2026 04:41

Copilot AI commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

@Bryan-Roe Thanks for sending me some feedback. Unfortunately, I hit an error while trying to use the custom Copilot setup steps configured for this repository. The error I am seeing is:

no `copilot-setup-steps` job found in your `copilot-setup-steps.yml` workflow file. Please ensure you have a single job named `copilot-setup-steps`. For more details, see https://gh.io/copilot/actions-setup-steps

Once you or someone with the necessary access fixes the problem, please let me know in a comment and I'll try again. Thanks!

@Bryan-Roe Bryan-Roe marked this pull request as ready for review July 11, 2026 05:43
Copilot AI review requested due to automatic review settings July 11, 2026 05:43

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Bryan-Roe, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@Bryan-Roe Bryan-Roe merged commit 5186cdb into main Jul 11, 2026
6 of 11 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Copilot AI commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

@Bryan-Roe Thanks for sending me some feedback. Unfortunately, I hit an error while trying to use the custom Copilot setup steps configured for this repository. The error I am seeing is:

no `copilot-setup-steps` job found in your `copilot-setup-steps.yml` workflow file. Please ensure you have a single job named `copilot-setup-steps`. For more details, see https://gh.io/copilot/actions-setup-steps

Once you or someone with the necessary access fixes the problem, please let me know in a comment and I'll try again. Thanks!

@Bryan-Roe Bryan-Roe deleted the copilot/fix-markdownlint-job branch July 11, 2026 05:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Narrows Markdown linting to exclude generated root guides and adds a contract assertion.

Changes:

  • Excludes docs/root-guides/* from lint targets.
  • Tests that the exclusion remains configured.
  • Review found stale local lint guidance.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/markdown-quality.yml Adds generated-guide exclusion.
tests/test_markdown_quality_workflow.py Verifies exclusion presence.


case "$file" in
*/node_modules/*|node_modules/*|*/.venv/*|.venv/*|*/venv/*|venv/*|*/.git/*|.git/*|*/dist/*|dist/*|*/build/*|build/*|*/.next/*|.next/*|*/.cache/*|.cache/*|data_out/*|mount/*|*/CHANGELOG.md|CHANGELOG.md)
*/node_modules/*|node_modules/*|*/.venv/*|.venv/*|*/venv/*|venv/*|*/.git/*|.git/*|*/dist/*|dist/*|*/build/*|build/*|*/.next/*|.next/*|*/.cache/*|.cache/*|data_out/*|mount/*|docs/root-guides/*|*/CHANGELOG.md|CHANGELOG.md)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants