Skip to content

Harden markdownlint target selection to skip generated root guides #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bryan-Roe merged 2 commits into from
Jul 11, 2026
+2 −1
Merged

Harden markdownlint target selection to skip generated root guides #849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a295799
Initial plan
Copilot Jul 11, 2026
be0b743
Exclude generated root guides from markdownlint targets
Copilot Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/markdown-quality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ jobs:
esac

case "$file" in
*/node_modules/*|node_modules/*|*/.venv/*|.venv/*|*/venv/*|venv/*|*/.git/*|.git/*|*/dist/*|dist/*|*/build/*|build/*|*/.next/*|.next/*|*/.cache/*|.cache/*|data_out/*|mount/*|*/CHANGELOG.md|CHANGELOG.md)
*/node_modules/*|node_modules/*|*/.venv/*|.venv/*|*/venv/*|venv/*|*/.git/*|.git/*|*/dist/*|dist/*|*/build/*|build/*|*/.next/*|.next/*|*/.cache/*|.cache/*|data_out/*|mount/*|docs/root-guides/*|*/CHANGELOG.md|CHANGELOG.md)
return 1
;;
esac
Expand Down
1 change: 1 addition & 0 deletions tests/test_markdown_quality_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ def test_markdown_quality_workflow_selects_changed_markdown_targets() -> None:

assert "git diff --name-only --diff-filter=ACMR -z" in select_step["run"]
assert 'git fetch --no-tags origin "$DEFAULT_BRANCH"' in select_step["run"]
assert "docs/root-guides/*" in select_step["run"]
assert "No Markdown files changed for this run" in lint_step["run"]
assert lint_step["env"]["EVENT_NAME"] == "${{ github.event_name }}"
assert 'markdownlint-cli2 "${args[@]}" "${markdown_files[@]}"' in lint_step["run"]
Expand Down
Loading