Skip to content

fix(tasks): reset Add Task dialog form fields on close#278

Closed
ShivaGupta-14 wants to merge 1 commit into
CCExtractor:mainfrom
ShivaGupta-14:fix/add-task-dialog-reset
Closed

fix(tasks): reset Add Task dialog form fields on close#278
ShivaGupta-14 wants to merge 1 commit into
CCExtractor:mainfrom
ShivaGupta-14:fix/add-task-dialog-reset

Conversation

@ShivaGupta-14
Copy link
Copy Markdown
Contributor

@ShivaGupta-14 ShivaGupta-14 commented Dec 14, 2025

Description

  • Added form reset logic in useEffect when dialog closes.
  • Clears description, priority, project, due, tags, and tagInput states.
  • Ensures clean form state when reopening Add Task dialog after cancel.

Additional Changes

  • Fixed col-span-3 styling by wrapping Input components in wrapper div
  • Added "None" option to priority dropdown
  • Renamed priority options for better clarity: High (H), Medium (M), Low (L)

Fixes: #277

Checklist

  • Ran npx prettier --write . (for formatting)
  • Ran gofmt -w . (for Go backend)
  • Ran npm test (for JS/TS testing)
  • Added unit tests, if applicable
  • Verified all tests pass
  • Updated documentation, if needed

Additional Notes

Self-Review

I've reviewed my changes and confirm:

  • All tests pass locally
  • Code follows existing test patterns in the project
  • Form reset works correctly on Cancel button click or clicking outside the dialog
  • Input field styling is now consistent across the dialog
  • No breaking changes to existing functionality

Video

Screen.Recording.2025-12-14.at.7.00.47.AM.mov

- Added form reset logic in useEffect when dialog closes.
- Clears description, priority, project, due, tags, and tagInput states.
- Ensures clean form state when reopening Add Task dialog after cancel.
- Fix col-span-3 styling by wrapping Input components in div
- Add "None" option and rename priority labels for clarity (High/Medium/Low)

Fixes: CCExtractor#277
@github-actions
Copy link
Copy Markdown

Thank you for opening this PR!

Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools.

Please take a moment to:

  • Check the "Files changed" tab
  • Leave comments on any lines for functions, comments, etc. that are important, non-obvious, or may need attention
  • Clarify decisions you made or areas you might be unsure about and/or any future updates being considered.
  • Finally, submit all the comments!

This helps make the review process smoother and gives us a clearer understanding of your thought process.

Once you've added your self-review, we'll continue from our side. Thank you!

@ShivaGupta-14
Copy link
Copy Markdown
Contributor Author

@its-me-abhishek, I’ve already completed the self-review and added it to the PR.

@its-me-abhishek
Copy link
Copy Markdown
Collaborator

Please add a self review similar to this

@its-me-abhishek its-me-abhishek added the invalid This doesn't seem right label Dec 21, 2025
@ShivaGupta-14 ShivaGupta-14 deleted the fix/add-task-dialog-reset branch December 26, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right self-review pending

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Task dialog form fields persist after closing/canceling

2 participants