Skip to content

fix(tasks): reset Add Task dialog form fields on close #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ShivaGupta-14 wants to merge 1 commit into from
Closed

fix(tasks): reset Add Task dialog form fields on close #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 31 additions & 28 deletions frontend/src/components/HomeComponents/Tasks/AddTaskDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,26 +80,27 @@ export const AddTaskdialog = ({
<Label htmlFor="description" className="text-right">
Description
</Label>
<Input
id="description"
name="description"
type="text"
value={newTask.description}
onChange={(e) =>
setNewTask({
...newTask,
description: e.target.value,
})
}
required
className="col-span-3"
/>
<div className="col-span-3">
<Input
id="description"
name="description"
type="text"
value={newTask.description}
onChange={(e) =>
setNewTask({
...newTask,
description: e.target.value,
})
}
required
/>
</div>
</div>
<div className="grid grid-cols-4 items-center gap-4">
<Label htmlFor="priority" className="text-right">
Priority
</Label>
<div className="col-span-1 flex items-center">
<div className="col-span-3 flex items-center">
<select
id="priority"
name="priority"
Expand All @@ -112,9 +113,10 @@ export const AddTaskdialog = ({
}
className="border rounded-md px-2 py-1 w-full bg-white text-black dark:bg-black dark:text-white transition-colors"
>
<option value="H">H</option>
<option value="M">M</option>
<option value="L">L</option>
<option value="">None</option>
<option value="H">High (H)</option>
<option value="M">Medium (M)</option>
<option value="L">Low (L)</option>
</select>
</div>
</div>
Expand Down Expand Up @@ -195,16 +197,17 @@ export const AddTaskdialog = ({
<Label htmlFor="description" className="text-right">
Tags
</Label>
<Input
id="tags"
name="tags"
placeholder="Add a tag"
value={tagInput}
onChange={(e) => setTagInput(e.target.value)}
onKeyDown={(e) => e.key === 'Enter' && handleAddTag()}
required
className="col-span-3"
/>
<div className="col-span-3">
<Input
id="tags"
name="tags"
placeholder="Add a tag"
value={tagInput}
onChange={(e) => setTagInput(e.target.value)}
onKeyDown={(e) => e.key === 'Enter' && handleAddTag()}
required
/>
</div>
</div>

<div className="mt-2">
Expand Down
8 changes: 8 additions & 0 deletions frontend/src/components/HomeComponents/Tasks/Tasks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,14 @@ export const Tasks = (
useEffect(() => {
if (!isAddTaskOpen) {
setIsCreatingNewProject(false);
setTagInput('');
setNewTask({
description: '',
priority: '',
project: '',
due: '',
tags: [],
});
}
}, [isAddTaskOpen]);

Expand Down
9 changes: 6 additions & 3 deletions frontend/src/components/HomeComponents/Tasks/__tests__/AddTaskDialog.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,9 +258,12 @@ describe('AddTaskDialog Component', () => {

const prioritySelect = screen.getByLabelText(/priority/i);

expect(prioritySelect).toContainHTML('<option value="H">H</option>');
expect(prioritySelect).toContainHTML('<option value="M">M</option>');
expect(prioritySelect).toContainHTML('<option value="L">L</option>');
expect(prioritySelect).toContainHTML('<option value="">None</option>');
expect(prioritySelect).toContainHTML('<option value="H">High (H)</option>');
expect(prioritySelect).toContainHTML(
'<option value="M">Medium (M)</option>'
);
expect(prioritySelect).toContainHTML('<option value="L">Low (L)</option>');
});

test('shows new project input when creating new project', () => {
Expand Down
50 changes: 50 additions & 0 deletions frontend/src/components/HomeComponents/Tasks/__tests__/Tasks.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,56 @@ describe('Tasks Component', () => {
expect(dropdown).toHaveValue('10');
});

test('reset form fields when Add Task dialog is closed via cancel button', async () => {
render(<Tasks {...mockProps} />);

expect(await screen.findByText('Task 1')).toBeInTheDocument();

const addTaskButton = screen.getByRole('button', { name: /add task/i });
fireEvent.click(addTaskButton);

const descriptionInput = screen.getByLabelText(/description/i);
fireEvent.change(descriptionInput, {
target: { value: 'New Task Description' },
});

expect(descriptionInput).toHaveValue('New Task Description');

const priorityInput = screen.getByLabelText(/priority/i);
fireEvent.change(priorityInput, { target: { value: 'L' } });

expect(priorityInput).toHaveValue('L');

const projectSelect = await screen.findByTestId('project-select');
fireEvent.change(projectSelect, { target: { value: 'ProjectA' } });

expect(projectSelect).toHaveValue('ProjectA');

const tagsInput = screen.getByPlaceholderText('Add a tag');
fireEvent.change(tagsInput, { target: { value: 'urgent' } });
fireEvent.keyDown(tagsInput, { key: 'Enter', code: 'Enter' });

expect(screen.getByText('urgent')).toBeInTheDocument();

const cancelButton = screen.getByRole('button', { name: /cancel/i });
fireEvent.click(cancelButton);

await waitFor(() => {
expect(screen.queryByText('Add a new task')).not.toBeInTheDocument();
});

fireEvent.click(addTaskButton);

const descriptionInputAfter = screen.getByLabelText(/description/i);
const priorityInputAfter = screen.getByLabelText(/priority/i);
const projectSelectAfter = await screen.findByTestId('project-select');

expect(descriptionInputAfter).toHaveValue('');
expect(priorityInputAfter).toHaveValue('');
expect(projectSelectAfter).toHaveValue('');
expect(screen.queryByText('urgent')).not.toBeInTheDocument();
});

test('loads "tasksPerPage" from localStorage on initial render', async () => {
localStorageMock.setItem('mockHashedKey', '20');

Expand Down
Loading