Skip to content

[T3118] FIX: overwriting default payment terms#324

Merged
NoeBerdoz merged 3 commits into
14.0from
T3118-payment-translation-terms
May 18, 2026
Merged

[T3118] FIX: overwriting default payment terms#324
NoeBerdoz merged 3 commits into
14.0from
T3118-payment-translation-terms

Conversation

@Danielgergely
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds German, Swiss French, and Italian translations for payment processing messages. Feedback was provided to ensure consistency in capitalization, punctuation, pluralization, and formal tone across the German and Swiss French translation files.

Comment thread my_compassion/i18n/de.po Outdated
Comment thread my_compassion/i18n/de.po Outdated
Comment thread my_compassion/i18n/fr_CH.po Outdated
Comment thread my_compassion/i18n/fr_CH.po Outdated
Copy link
Copy Markdown
Contributor

@NoeBerdoz NoeBerdoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

# Conflicts:
#	my_compassion/i18n/de.po
#	my_compassion/i18n/fr_CH.po
#	my_compassion/i18n/it.po
Copy link
Copy Markdown
Contributor

@NoeBerdoz NoeBerdoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NoeBerdoz NoeBerdoz merged commit 27f1e72 into 14.0 May 18, 2026
1 check passed
@NoeBerdoz NoeBerdoz deleted the T3118-payment-translation-terms branch May 18, 2026 11:47
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 18, 2026

Confidence Score: 4/5

Safe to merge after fixing the missing blank line and typo in fr_CH.po; the other two files are clean.

The German and Italian translations are correct and well-formed. The Swiss-French file has a missing blank-line separator between the two new PO entries, which can cause parsers to misread or skip the second entry and leave French-speaking users seeing the English fallback for single-payment messages. There is also a spelling error ("paiments" instead of "paiements") that would be shown verbatim on screen.

my_compassion/i18n/fr_CH.po needs a blank-line separator added between the two new entries and the typo "paiments" corrected to "paiements".

Important Files Changed

Filename Overview
my_compassion/i18n/de.po Adds German translations for two payment processing messages and fixes the missing newline at the end of the previous last entry. Blank-line separators between entries are correct.
my_compassion/i18n/fr_CH.po Adds Swiss-French translations for two payment processing messages, but the blank-line separator between the two new entries is missing (unlike de.po and it.po), which can cause PO parsing failures. Also contains a typo: "paiments" should be "paiements".
my_compassion/i18n/it.po Adds Italian translations for two payment processing messages and fixes the missing newline at the end of the previous last entry. Entry formatting is correct.

Sequence Diagram

sequenceDiagram
    participant Browser
    participant OdooPaymentJS as payment_processing.js
    participant i18n as PO Translation Layer

    Browser->>OdooPaymentJS: Initiate payment
    OdooPaymentJS->>i18n: Lookup "We are processing your payment(s), please wait ..."
    alt Translation found in de/fr_CH/it .po
        i18n-->>OdooPaymentJS: Return localised string
    else No translation (missing or malformed entry)
        i18n-->>OdooPaymentJS: Fall back to English default
    end
    OdooPaymentJS-->>Browser: Display status message (localised or English fallback)
Loading

Reviews (1): Last reviewed commit: "Merge branch '14.0' into T3118-payment-t..." | Re-trigger Greptile

Comment on lines +4737 to +4738
msgstr "Nous traitons tes paiments, merci de rester patient ..."
#. module: payment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Missing blank line between PO entries. The fr_CH.po file omits the required blank-line separator between the two new entries (unlike de.po and it.po which are correct). Some PO parsers treat the missing separator as a malformed entry and may silently skip or merge the second translation, causing the "We are processing your payment, please wait ..." string to fall back to the English default at runtime.

Suggested change
msgstr "Nous traitons tes paiments, merci de rester patient ..."
#. module: payment
msgstr "Nous traitons tes paiments, merci de rester patient ..."
#. module: payment

#: code:addons/payment/static/src/js/payment_processing.js:0
#, python-format
msgid "We are processing your payments, please wait ..."
msgstr "Nous traitons tes paiments, merci de rester patient ..."
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Typo in French translation: paiments should be paiements. This typo will be rendered verbatim to French-speaking users when multiple payments are being processed.

Suggested change
msgstr "Nous traitons tes paiments, merci de rester patient ..."
msgstr "Nous traitons tes paiements, merci de rester patient ..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants