[T3118] FIX: overwriting default payment terms#324
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds German, Swiss French, and Italian translations for payment processing messages. Feedback was provided to ensure consistency in capitalization, punctuation, pluralization, and formal tone across the German and Swiss French translation files.
# Conflicts: # my_compassion/i18n/de.po # my_compassion/i18n/fr_CH.po # my_compassion/i18n/it.po
Confidence Score: 4/5Safe to merge after fixing the missing blank line and typo in fr_CH.po; the other two files are clean. The German and Italian translations are correct and well-formed. The Swiss-French file has a missing blank-line separator between the two new PO entries, which can cause parsers to misread or skip the second entry and leave French-speaking users seeing the English fallback for single-payment messages. There is also a spelling error ("paiments" instead of "paiements") that would be shown verbatim on screen. my_compassion/i18n/fr_CH.po needs a blank-line separator added between the two new entries and the typo "paiments" corrected to "paiements". Important Files Changed
Sequence DiagramsequenceDiagram
participant Browser
participant OdooPaymentJS as payment_processing.js
participant i18n as PO Translation Layer
Browser->>OdooPaymentJS: Initiate payment
OdooPaymentJS->>i18n: Lookup "We are processing your payment(s), please wait ..."
alt Translation found in de/fr_CH/it .po
i18n-->>OdooPaymentJS: Return localised string
else No translation (missing or malformed entry)
i18n-->>OdooPaymentJS: Fall back to English default
end
OdooPaymentJS-->>Browser: Display status message (localised or English fallback)
Reviews (1): Last reviewed commit: "Merge branch '14.0' into T3118-payment-t..." | Re-trigger Greptile |
| msgstr "Nous traitons tes paiments, merci de rester patient ..." | ||
| #. module: payment |
There was a problem hiding this comment.
Missing blank line between PO entries. The
fr_CH.po file omits the required blank-line separator between the two new entries (unlike de.po and it.po which are correct). Some PO parsers treat the missing separator as a malformed entry and may silently skip or merge the second translation, causing the "We are processing your payment, please wait ..." string to fall back to the English default at runtime.
| msgstr "Nous traitons tes paiments, merci de rester patient ..." | |
| #. module: payment | |
| msgstr "Nous traitons tes paiments, merci de rester patient ..." | |
| #. module: payment |
| #: code:addons/payment/static/src/js/payment_processing.js:0 | ||
| #, python-format | ||
| msgid "We are processing your payments, please wait ..." | ||
| msgstr "Nous traitons tes paiments, merci de rester patient ..." |
There was a problem hiding this comment.
Typo in French translation:
paiments should be paiements. This typo will be rendered verbatim to French-speaking users when multiple payments are being processed.
| msgstr "Nous traitons tes paiments, merci de rester patient ..." | |
| msgstr "Nous traitons tes paiements, merci de rester patient ..." |
No description provided.