Skip to content

[T3118] FIX: overwriting default payment terms #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NoeBerdoz merged 3 commits into from
May 18, 2026
Merged

[T3118] FIX: overwriting default payment terms #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8903c0
[T3118] FIX: overwriting default payment terms
Danielgergely Apr 21, 2026
9eac27b
[T3118] FIX: corrected translations
Danielgergely Apr 21, 2026
107bf17
Merge branch '14.0' into T3118-payment-translation-terms
NoeBerdoz May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion my_compassion/i18n/de.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4783,4 +4783,16 @@ msgstr "Registrieren"
msgid ""
"Given the time it takes for mail to arrive, it could take between one and "
"three months for you to receive a reply."
msgstr "Aufgrund des langen Weges eines Briefes kann es 1-3 Monate dauern, bis du eine Antwort erhältst."
msgstr "Aufgrund des langen Weges eines Briefes kann es 1-3 Monate dauern, bis du eine Antwort erhältst."

#. module: payment
#: code:addons/payment/static/src/js/payment_processing.js:0
#, python-format
msgid "We are processing your payments, please wait ..."
msgstr "Wir bearbeiten Deine Zahlungen, bitte warte kurz ..."

#. module: payment
#: code:addons/payment/static/src/js/payment_processing.js:0
#, python-format
msgid "We are processing your payment, please wait ..."
msgstr "Wir bearbeiten Deine Zahlung, bitte warte kurz ..."
13 changes: 12 additions & 1 deletion my_compassion/i18n/fr_CH.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4728,4 +4728,15 @@ msgstr "S'inscrire"
msgid ""
"Given the time it takes for mail to arrive, it could take between one and "
"three months for you to receive a reply."
msgstr "Compte tenu des délais de livraison des lettres, la réponse pourrait vous parvenir entre un et trois mois."
msgstr "Compte tenu des délais de livraison des lettres, la réponse pourrait vous parvenir entre un et trois mois."

#. module: payment
#: code:addons/payment/static/src/js/payment_processing.js:0
#, python-format
msgid "We are processing your payments, please wait ..."
msgstr "Nous traitons tes paiments, merci de rester patient ..."
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Typo in French translation: paiments should be paiements. This typo will be rendered verbatim to French-speaking users when multiple payments are being processed.

Suggested change
msgstr "Nous traitons tes paiments, merci de rester patient ..."
msgstr "Nous traitons tes paiements, merci de rester patient ..."

#. module: payment
Comment on lines +4737 to +4738
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Missing blank line between PO entries. The fr_CH.po file omits the required blank-line separator between the two new entries (unlike de.po and it.po which are correct). Some PO parsers treat the missing separator as a malformed entry and may silently skip or merge the second translation, causing the "We are processing your payment, please wait ..." string to fall back to the English default at runtime.

Suggested change
msgstr "Nous traitons tes paiments, merci de rester patient ..."
#. module: payment
msgstr "Nous traitons tes paiments, merci de rester patient ..."
#. module: payment

#: code:addons/payment/static/src/js/payment_processing.js:0
#, python-format
msgid "We are processing your payment, please wait ..."
msgstr "Nous traitons ton paiement, merci de rester patient ..."
14 changes: 13 additions & 1 deletion my_compassion/i18n/it.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4793,4 +4793,16 @@ msgstr "Iscriviti"
msgid ""
"Given the time it takes for mail to arrive, it could take between one and "
"three months for you to receive a reply."
msgstr "Considerando i tempi di consegna della posta, la risposta potrebbe arrivare tra uno e tre mesi."
msgstr "Considerando i tempi di consegna della posta, la risposta potrebbe arrivare tra uno e tre mesi."

#. module: payment
#: code:addons/payment/static/src/js/payment_processing.js:0
#, python-format
msgid "We are processing your payments, please wait ..."
msgstr "Stiamo elaborando i tuoi pagamenti, attendi prego..."

#. module: payment
#: code:addons/payment/static/src/js/payment_processing.js:0
#, python-format
msgid "We are processing your payment, please wait ..."
msgstr "Stiamo elaborando il tuo pagamento, attendi prego ..."
Loading