T3135 german translation fixes#325
Merged
Merged
Conversation
Member
Danielgergely
commented
Apr 21, 2026
Danielgergely
commented
- FIX: my donations page translation fixes
- FIX: sentence ending period now comes directly after the last word. (no space in between)
- FIX: father occupation corrected
- FIX: sentence ending period now comes directly after the last word. (no space in between) - FIX: father occupation corrected
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates translations in German, French, and Italian and refactors the child timeline template to improve sentence structure and punctuation, specifically aiming to remove unwanted spaces before periods. While the refactoring for the "sisters" and job description blocks correctly addresses the spacing issue, a bug was identified in the logic for the "brothers" section where a leading space before the period still persists, failing to fully resolve the issue for that specific case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.