chore(rec-28): re-file tracking issues + repoint 51 @Ignore annotations to new numbers#70
Merged
Merged
Conversation
…ns to new numbers The 2026-05-24 repo-deletion incident destroyed the 18 GitHub tracking issues that the in-tree `@Ignore` annotations referenced. The deadline labels (`ignore:1y` etc.) were recreated on the new repo with zero applications; the issue references in code were dangling. Closes audit finding #5 from the 2026-05-26 self-audit. Re-filed 15 issues on the new repo with the `ignore:1y` label and the appropriate `lane:*` routing label. Each new issue body cites the in-tree file(s) it tracks and explains the test-skip context. Issue-number remap (old → new): NationalSecurityAgency#159 → #55 x86 scalar-disasm divergence — x86AssemblyTest NationalSecurityAgency#160 → #56 dsPIC30F W4 label-vs-register — dsPIC30FAssemblyTest NationalSecurityAgency#161 → #57 SymbolPathParser detailed-processing better-results NationalSecurityAgency#176 → #58 LLDB EXC_BAD_ACCESS on string allocation NationalSecurityAgency#177 → #59 LLDB temp var $x semantics NationalSecurityAgency#179 → #60 Debugger RMI integration test cluster NationalSecurityAgency#180 → #61 LldbConnectorsTest TODO NationalSecurityAgency#181 → #62 JitJvmTypeUtilsTest Java-version-bound (manual-tool) NationalSecurityAgency#183 → #63 AbstractToyJitCodeGenerator undefined-cases NationalSecurityAgency#187 → #64 MDMangBaseTest demangler corpus NationalSecurityAgency#188 → #65 HexagonPcodeUseropLibraryTest DFP NaN handling NationalSecurityAgency#189 → #66 Debug/TraceModeling cluster NationalSecurityAgency#191 → #67 Debugger plugin cluster NationalSecurityAgency#192 → #68 misc cluster NationalSecurityAgency#193 → #69 DBCachedObjectStore + TenetLoader correctness review 3 dead numbers were NOT re-filed because nothing in current code references them: - NationalSecurityAgency#162 (ARM/x64 dead `//@Ignore`s, already removed pre-deletion) - NationalSecurityAgency#178 (JavaMethodsTest flaky, collapsed in #28-6a) - NationalSecurityAgency#190 (ProjectExperimentsTest, file deleted in earlier sweep) - NationalSecurityAgency#182 (never observed in any annotation) Code change scope is narrow: - 21 test files: `@Ignore("...#OLD")` → `@Ignore("...#NEW")` only on lines containing `@Ignore` (sed address). Android OAT/ART source files in `Ghidra/Features/FileFormats/` are NOT touched — those reference these same numbers in unrelated contexts (Android API versions, image-method offsets, etc.). - 1 doc file: `docs/testing/ignore-test-inventory.md` — "six audit-named tests" table updated to current annotation strings, `#28-4` and `#28-6c` sequencing rows updated to record the remap, "sweep heuristics §" issue references updated. Verification: - 51 in-tree `@Ignore` annotations, all referencing `#55`–`#69`. - Census unchanged: 31 wip / 19 blocked-on / 1 manual-tool / 51. - `gradle ignoreAudit` still finds zero violations (annotations still carry category prefix + `#N` ref). Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/ Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2026-05-24 repo-deletion incident destroyed the 18 GitHub tracking issues that the in-tree
@Ignoreannotations referenced. The deadline labels (ignore:1yetc.) were recreated on the new repo with zero applications; the issue references in code were dangling. Closes audit finding #5 from the 2026-05-26 self-audit.Re-filed 15 issues on the new repo with
ignore:1y+ appropriatelane:*routing label. Each new issue body cites the in-tree file(s) it tracks and explains the test-skip context.Remap (old → new):
$xsemantics3 dead numbers were NOT re-filed because nothing in current code references them: NationalSecurityAgency#162 (ARM/x64 dead
//@Ignores, removed pre-deletion), NationalSecurityAgency#178 (JavaMethodsTest flaky, collapsed in #28-6a), NationalSecurityAgency#190 (ProjectExperimentsTest, file deleted in earlier sweep), NationalSecurityAgency#182 (never observed in any annotation).Code change scope is narrow:
@Ignore("...#OLD")→@Ignore("...#NEW")only on lines containing@Ignore(sed address). Android OAT/ART source files inGhidra/Features/FileFormats/are NOT touched — those reference these same numbers in unrelated contexts (Android API versions, image-method offsets, etc.).docs/testing/ignore-test-inventory.md— "six audit-named tests" table updated to current annotation strings,#28-4and#28-6csequencing rows updated to record the remap, "sweep heuristics §" issue references updated.Verification:
@Ignoreannotations, all referencing#55–#69.gradle ignoreAuditstill finds zero violations (annotations still carry category prefix +#Nref).Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/