Skip to content

chore(rec-28): re-file tracking issues + repoint 51 @Ignore annotations to new numbers #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CryptoJones merged 1 commit into from
May 26, 2026
Merged

chore(rec-28): re-file tracking issues + repoint 51 @Ignore annotations to new numbers #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ework-TraceModeling/src/test/java/ghidra/dbg/target/schema/XmlTargetObjectSchemaTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public void testDeserialize() throws JDOMException, IOException {
}

@Test
@Ignore("blocked-on: XmlTargetObjectSchema null-intent design fix #189")
@Ignore("blocked-on: XmlTargetObjectSchema null-intent design fix #66")
public void testSearchWithMultipleImpls() throws Exception {
SchemaContext ctx = XmlSchemaContext.deserialize("""
<context>
Expand Down
4 changes: 2 additions & 2 deletions ...rk-TraceModeling/src/test/java/ghidra/trace/database/data/DBTraceDataTypeManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ public void testAddAndGet() {
}

@Test
@Ignore("wip: Debug/TraceModeling cluster #189")
@Ignore("wip: Debug/TraceModeling cluster #66")
public void testAddRemoveUndoThenGet() throws IOException {
StructureDataType mine = getTestDataType();
DataTypePath minePath = mine.getDataTypePath();
Expand Down Expand Up @@ -158,7 +158,7 @@ public void testChangeDataType() {
}

@Test
@Ignore("wip: Debug/TraceModeling cluster #189")
@Ignore("wip: Debug/TraceModeling cluster #66")
public void testReplaceDataType() throws DataTypeDependencyException {
StructureDataType mineA = getTestDataType();
DataTypePath mineAPath = mineA.getDataTypePath();
Expand Down
4 changes: 2 additions & 2 deletions .../src/test/java/ghidra/trace/database/map/DBTraceAddressSnapRangePropertyMapSpaceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ public void testGetDataByKey() {
}

@Test
@Ignore("wip: Debug/TraceModeling cluster #189")
@Ignore("wip: Debug/TraceModeling cluster #66")
public void testSaveAndLoad() throws IOException, CancelledException, VersionException {
MyEntry entry1;
try (Transaction tx = obj.openTransaction("Create entries")) {
Expand All @@ -372,7 +372,7 @@ public void testSaveAndLoad() throws IOException, CancelledException, VersionExc
}

@Test
@Ignore("blocked-on: DBTrace snap-range related to GP-479 #189")
@Ignore("blocked-on: DBTrace snap-range related to GP-479 #66")
public void testUndoThenRedo() throws IOException {
MyEntry entry1;
try (Transaction tx = obj.openTransaction("Create entries")) {
Expand Down
4 changes: 2 additions & 2 deletions ...rk-TraceModeling/src/test/java/ghidra/trace/database/module/DBTraceModuleManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ public void testSaveThenLoad() throws Exception {
}

@Test
@Ignore("blocked-on: write-back cache undo unsupported #189")
@Ignore("blocked-on: write-back cache undo unsupported #66")
public void testUndoIdentitiesPreserved() throws Exception {
TraceModule mod1;
try (Transaction tx = b.startTransaction()) {
Expand All @@ -362,7 +362,7 @@ public void testUndoIdentitiesPreserved() throws Exception {
}

@Test
@Ignore("blocked-on: write-back cache undo unsupported #189")
@Ignore("blocked-on: write-back cache undo unsupported #66")
public void testUndoThenRedo() throws Exception {
TraceModule mod1;
TraceModule mod2;
Expand Down
2 changes: 1 addition & 1 deletion ...ebug/ProposedUtils/src/test/java/ghidra/util/database/DBCachedObjectStoreFactoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,7 @@ public void testAbstractColumns() throws IOException, VersionException {
}

@Test
@Ignore("wip: DBCachedObjectStoreFactory test correctness review #193")
@Ignore("wip: DBCachedObjectStoreFactory test correctness review #69")
public void testCodecs() throws IOException, VersionException {

DBHandle handle = new DBHandle();
Expand Down
2 changes: 1 addition & 1 deletion Ghidra/Features/Base/src/test/java/ghidra/app/util/html/HTMLDataTypeRepresentationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,7 +745,7 @@ public void testTypeDefDiff_Arrays_SameArrays_DifferentNames() {
* Test marked as ignored pending HTML rendering fix - see GP-1974
*/
@Test
@Ignore("wip: misc cluster — undocumented bare-ignore #192")
@Ignore("wip: misc cluster — undocumented bare-ignore #68")
public void testTypeDefDiff_ArraysOfStructures_DifferentStructures() {

Structure s1 = getStructWithEnum();
Expand Down
2 changes: 1 addition & 1 deletion ...rDependent/src/test/java/ghidra/app/plugin/core/decompiler/taint/DecompilerTaintTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ public void tearDown() throws Exception {

// NB: This test is VERY slow. I do not recommend running it on a regular basis.
// Each of the 22 paired examples above takes close to a minute to run, so...
@Ignore("wip: misc cluster — undocumented bare-ignore #192")
@Ignore("wip: misc cluster — undocumented bare-ignore #68")
@Test
public void testWinmine() throws Exception {
int nf = 0;
Expand Down
18 changes: 9 additions & 9 deletions Ghidra/Features/MicrosoftDmang/src/test/java/mdemangler/MDMangBaseTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14537,7 +14537,7 @@ public void testCatch_1() throws Exception {
}

//From gray.cpp
@Ignore("wip: MDMangBaseTest undocumented bare-ignore #187")
@Ignore("wip: MDMangBaseTest undocumented bare-ignore #64")
//@Test
public void testCatch_2() throws Exception {
mangled = "__catch$_main$0";
Expand Down Expand Up @@ -14965,7 +14965,7 @@ public void testEnumType() throws Exception {
// MSFT CLI symbol from loader. Has anonymous namespace (mangled), a dot delimiter to
// represent namespace delimiter, and then a "normal" name (which in this case is a
// demangled name with spaces).
@Ignore("wip: MDMangBaseTest undocumented bare-ignore #187")
@Ignore("wip: MDMangBaseTest undocumented bare-ignore #64")
public void testDotSeparatedSymbolCliOrig() throws Exception {
mangled = "?A0xfedcba98.name0<struct _name1,struct _name2 const >";
msTruth = "";
Expand All @@ -14979,7 +14979,7 @@ public void testDotSeparatedSymbolCliOrig() throws Exception {
// SymbolUtilities gets a hold of them... this is generally contrary to what we would want,
// but if we cannot lay down symbols with spaces, then we need to make sure we can still
// operate either way
@Ignore("wip: MDMangBaseTest undocumented bare-ignore #187")
@Ignore("wip: MDMangBaseTest undocumented bare-ignore #64")
public void testDotSeparatedSymbolCliWithUnderscores() throws Exception {
mangled = "?A0xfedcba98.name0<struct__name1,struct__name2_const_>";
msTruth = "";
Expand All @@ -14988,7 +14988,7 @@ public void testDotSeparatedSymbolCliWithUnderscores() throws Exception {
}

// Complete LLVM type symbol with weak prefix and associated suffix
@Ignore("wip: MDMangBaseTest undocumented bare-ignore #187")
@Ignore("wip: MDMangBaseTest undocumented bare-ignore #64")
public void testLLVMWeakPrefixDefaultXmmSuffix() throws Exception {
mangled = ".weak.??_7name0@@6B@.default.__xmm@aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
//llTruth = ""; // fail
Expand All @@ -14999,7 +14999,7 @@ public void testLLVMWeakPrefixDefaultXmmSuffix() throws Exception {

// Not expected to be a true symbol, but want to understand partial processing with
// complete suffix
@Ignore("wip: MDMangBaseTest undocumented bare-ignore #187")
@Ignore("wip: MDMangBaseTest undocumented bare-ignore #64")
public void testVftableLLVMWeakPartial1() throws Exception {
mangled = "??_7name0@@6B@.default.__xmm@aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
//llTruth = "const name0::`vftable'";
Expand All @@ -15010,7 +15010,7 @@ public void testVftableLLVMWeakPartial1() throws Exception {

// Not expected to be a true symbol, but want to understand partial processing with
// partial suffix
@Ignore("wip: MDMangBaseTest undocumented bare-ignore #187")
@Ignore("wip: MDMangBaseTest undocumented bare-ignore #64")
public void testVftableLLVMWeakPartial2() throws Exception {
mangled = "??_7name0@@6B@.default";
//llTruth = "const name0::`vftable'";
Expand All @@ -15019,7 +15019,7 @@ public void testVftableLLVMWeakPartial2() throws Exception {
demangleAndTest();
}

@Ignore("wip: MDMangBaseTest undocumented bare-ignore #187")
@Ignore("wip: MDMangBaseTest undocumented bare-ignore #64")
public void testVftable() throws Exception {
mangled = "??_7name0@@6B@";
msTruth = "const name0::`vftable'";
Expand All @@ -15032,7 +15032,7 @@ public void testVftable() throws Exception {
// the suffix "3@" is almost like a backreference tag with the '@' closing the full
// qualified name... except... we've seen numbers that are beyond the backref range as
// here, but also have seen numbers like 18.
@Ignore("wip: MDMangBaseTest undocumented bare-ignore #187")
@Ignore("wip: MDMangBaseTest undocumented bare-ignore #64")
public void testMangledTypeWithNamespaceSuffix() throws Exception {
mangled = ".?AT<unnamed-tag>@name0::3@";
msTruth = "";
Expand Down Expand Up @@ -15666,7 +15666,7 @@ public void testVCallL816() throws Exception {
//=====================

//TODO: ignore for now.
@Ignore("wip: MDMangBaseTest undocumented bare-ignore #187")
@Ignore("wip: MDMangBaseTest undocumented bare-ignore #64")
public void testFuzzyFit() throws Exception {
MDFuzzyFit ff = new MDFuzzyFit();
//from: testWin10_0358058()
Expand Down
2 changes: 1 addition & 1 deletion Ghidra/Framework/Emulation/src/test/java/ghidra/pcode/emu/jit/JitJvmTypeUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

import ghidra.pcode.emu.jit.JitPassage.AddrCtx;

@Ignore("manual-tool: tightly bound to Java version #181")
@Ignore("manual-tool: tightly bound to Java version #62")
public class JitJvmTypeUtilsTest {

public static class HasFieldTypeSignatures {
Expand Down
2 changes: 1 addition & 1 deletion ...ftwareModeling/src/test/java/ghidra/app/plugin/assembler/sleigh/dsPIC30FAssemblyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public void testAssemble_call_W0() {
}

@Test
@Ignore("blocked-on: dsPIC30F W4 label-vs-register #160")
@Ignore("blocked-on: dsPIC30F W4 label-vs-register #56")
public void testAssemble_clr_b_W4() {
assertOneCompatRestExact("clr.b W4", "00:42:eb:00", 0x000100);
}
Expand Down
2 changes: 1 addition & 1 deletion ...rk/SoftwareModeling/src/test/java/ghidra/app/plugin/assembler/sleigh/x86AssemblyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ protected LanguageID getLanguageID() {
}

@Test
@Ignore("blocked-on: x86 scalar-disasm divergence #159")
@Ignore("blocked-on: x86 scalar-disasm divergence #55")
public void testAssemble_ADD_ECX_mEBX_n0x8m() {
try {
assertOneCompatRestExact("ADD ECX,dword ptr [EDX + -0x8]", "03:4a:f8");
Expand Down
2 changes: 1 addition & 1 deletion Ghidra/Framework/SoftwareModeling/src/test/java/ghidra/app/util/SymbolPathParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public void testCliPinptrMSFTVersion_NaiveProcessing() {
}

// Testing for detailed processing. Same as above test, but expecting better results.
@Ignore("wip: SymbolPathParser detailed-processing better-results #161")
@Ignore("wip: SymbolPathParser detailed-processing better-results #57")
public void testCliPinptrMSFTVersion_DetailedProcessing() {
List<String> list = SymbolPathParser.parse("namespace::ta<cli::pin_ptr" +
"<unsigned char * __ptr64,class System::Text::Encoding ^ __ptr64>");
Expand Down
8 changes: 4 additions & 4 deletions ...cessors/Hexagon/src/test/java/ghidra/program/emulation/HexagonPcodeUseropLibraryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,25 +173,25 @@ public void testDfmpyhhOnes() throws Exception {
}

@Test
@Ignore("wip: HexagonPcodeUseropLibraryTest undocumented bare-ignore #188")
@Ignore("wip: HexagonPcodeUseropLibraryTest undocumented bare-ignore #65")
public void testDfmpyhhZeroAnyQNan() throws Exception {
runTestDfmpyhh(DF_HEX_NAN, DF_ZERO, DF_ANY, DF_QNAN);
}

@Test
@Ignore("wip: HexagonPcodeUseropLibraryTest undocumented bare-ignore #188")
@Ignore("wip: HexagonPcodeUseropLibraryTest undocumented bare-ignore #65")
public void testDfmpyhhZeroAnySNan() throws Exception {
runTestDfmpyhh(DF_HEX_NAN, DF_ZERO, DF_ANY, DF_SNAN);
}

@Test
@Ignore("wip: HexagonPcodeUseropLibraryTest undocumented bare-ignore #188")
@Ignore("wip: HexagonPcodeUseropLibraryTest undocumented bare-ignore #65")
public void testDfmpyhhZeroQNanSNan() throws Exception {
runTestDfmpyhh(DF_HEX_NAN, DF_ZERO, DF_QNAN, DF_SNAN);
}

@Test
@Ignore("wip: HexagonPcodeUseropLibraryTest undocumented bare-ignore #188")
@Ignore("wip: HexagonPcodeUseropLibraryTest undocumented bare-ignore #65")
public void testDfmpyhhZeroSNanQNan() throws Exception {
runTestDfmpyhh(DF_HEX_NAN, DF_ZERO, DF_SNAN, DF_QNAN);
}
Expand Down
2 changes: 1 addition & 1 deletion Ghidra/Test/DebuggerIntegrationTest/src/test.slow/java/agent/java/rmi/JavaCommandsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
import ghidra.trace.model.time.TraceSnapshot;
import ghidra.util.Msg;

@Ignore("wip: Debugger RMI integration tests — undocumented bare-ignore #179")
@Ignore("wip: Debugger RMI integration tests — undocumented bare-ignore #60")
public class JavaCommandsTest extends AbstractJavaTraceRmiTest {

public static final String HWSETUP = """
Expand Down
2 changes: 1 addition & 1 deletion Ghidra/Test/DebuggerIntegrationTest/src/test.slow/java/agent/java/rmi/JavaHooksTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
import ghidra.trace.model.target.TraceObject;
import ghidra.trace.model.target.TraceObjectValue;

@Ignore("wip: Debugger RMI integration tests — undocumented bare-ignore #179")
@Ignore("wip: Debugger RMI integration tests — undocumented bare-ignore #60")
public class JavaHooksTest extends AbstractJavaTraceRmiTest {

@Test
Expand Down
2 changes: 1 addition & 1 deletion Ghidra/Test/DebuggerIntegrationTest/src/test.slow/java/agent/java/rmi/JavaMethodsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
import ghidra.trace.model.target.TraceObject;
import ghidra.trace.model.target.TraceObjectValue;

@Ignore("wip: Debugger RMI integration tests — undocumented bare-ignore #179")
@Ignore("wip: Debugger RMI integration tests — undocumented bare-ignore #60")
public class JavaMethodsTest extends AbstractJavaTraceRmiTest {

/**
Expand Down
24 changes: 12 additions & 12 deletions Ghidra/Test/DebuggerIntegrationTest/src/test.slow/java/agent/lldb/rmi/LldbCommandsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,30 +698,30 @@ public void testSetValueLong() throws Exception {
}

@Test
@Ignore("blocked-on: LLDB EXC_BAD_ACCESS on string allocation #176")
@Ignore("blocked-on: LLDB EXC_BAD_ACCESS on string allocation #58")
public void testSetValueString() throws Exception {
assertEquals("\"Hello World!\"", runTestSetValue("", """
'"Hello World!"'\
""", ""));
}

@Test
@Ignore("blocked-on: LLDB EXC_BAD_ACCESS on string allocation #176")
@Ignore("blocked-on: LLDB EXC_BAD_ACCESS on string allocation #58")
public void testSetValueStringWide() throws Exception {
assertEquals("L\"Hello World!\"", runTestSetValue("", """
'L"Hello World!"'\
""", ""));
}

@Test
@Ignore("blocked-on: LLDB temp var $x #177")
@Ignore("blocked-on: LLDB temp var $x #59")
public void testSetValueBoolArr() throws Exception {
assertArrayEquals(new boolean[] { true, false },
runTestSetValue("expr bool $x[2]={ true, false }", "$x", ""));
}

@Test
@Ignore("blocked-on: LLDB EXC_BAD_ACCESS on string allocation #176")
@Ignore("blocked-on: LLDB EXC_BAD_ACCESS on string allocation #58")
public void testSetValueByteArrUsingString() throws Exception {
// Because explicit array type is chosen, we get null terminator
assertArrayEquals(new byte[] { 'H', 0, 'W', 0 }, runTestSetValue("", """
Expand All @@ -730,14 +730,14 @@ public void testSetValueByteArrUsingString() throws Exception {
}

@Test
@Ignore("blocked-on: LLDB temp var $x #177")
@Ignore("blocked-on: LLDB temp var $x #59")
public void testSetValueByteArrUsingArray() throws Exception {
assertArrayEquals(new byte[] { 'H', 0, 'W' },
runTestSetValue("expr char $x[]={'H', 0, 'W'}", "$x", "BYTE_ARR"));
}

@Test
@Ignore("blocked-on: LLDB EXC_BAD_ACCESS on string allocation #176")
@Ignore("blocked-on: LLDB EXC_BAD_ACCESS on string allocation #58")
public void testSetValueCharArrUsingString() throws Exception {
// Because explicit array type is chosen, we get null terminator
assertArrayEquals(new char[] { 'H', 0, 'W', 0 }, runTestSetValue("", """
Expand All @@ -746,44 +746,44 @@ public void testSetValueCharArrUsingString() throws Exception {
}

@Test
@Ignore("blocked-on: LLDB temp var $x #177")
@Ignore("blocked-on: LLDB temp var $x #59")
public void testSetValueCharArrUsingArray() throws Exception {
assertArrayEquals(new char[] { 'H', 0, 'W' },
runTestSetValue("expr char $x[]={'H', 0, 'W'}", "$x", "CHAR_ARR"));
}

@Test
@Ignore("blocked-on: LLDB temp var $x #177")
@Ignore("blocked-on: LLDB temp var $x #59")
public void testSetValueShortArrUsingString() throws Exception {
// Because explicit array type is chosen, we get null terminator
assertArrayEquals(new short[] { 'H', 0, 'W', 0 },
runTestSetValue("expr wchar_t $x[]=L\"H\\0W\"", "$x", "SHORT_ARR"));
}

@Test
@Ignore("blocked-on: LLDB temp var $x #177")
@Ignore("blocked-on: LLDB temp var $x #59")
public void testSetValueShortArrUsingArray() throws Exception {
assertArrayEquals(new short[] { 'H', 0, 'W' },
runTestSetValue("expr short $x[]={'H', 0, 'W'}", "$x", "SHORT_ARR"));
}

@Test
@Ignore("blocked-on: LLDB temp var $x #177")
@Ignore("blocked-on: LLDB temp var $x #59")
public void testSetValueIntArrayUsingMixedArray() throws Exception {
// Because explicit array type is chosen, we get null terminator
assertArrayEquals(new int[] { 'H', 0, 'W' },
runTestSetValue("expr int $x[]={'H', 0, 'W'}", "$x", "INT_ARR"));
}

@Test
@Ignore("blocked-on: LLDB temp var $x #177")
@Ignore("blocked-on: LLDB temp var $x #59")
public void testSetValueIntArrUsingArray() throws Exception {
assertArrayEquals(new int[] { 1, 2, 3, 4 },
runTestSetValue("expr int $x[]={1,2,3,4}", "$x", ""));
}

@Test
@Ignore("blocked-on: LLDB temp var $x #177")
@Ignore("blocked-on: LLDB temp var $x #59")
public void testSetValueLongArr() throws Exception {
assertArrayEquals(new long[] { 1, 2, 3, 4 },
runTestSetValue("expr long long $x[]={1LL,2LL,3LL,4LL}", "$x", ""));
Expand Down
Loading
Loading