feat(agoric): support mint parameter governance updates#75
Open
dckc wants to merge 3 commits into
Open
Conversation
✅ Deploy Preview for cosmos-proposal-builder ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dckc
force-pushed
the
feat-issue-73-mint-params
branch
3 times, most recently
from
5ede41f to
8ef0572
Compare
Add end-to-end mint parameter proposal support in the Agoric flow, including querying, editing, message construction, and user-facing error handling. This replaces legacy x/params subspace submission for mint changes with the supported Cosmos SDK v0.50 governance message path: - submit `/cosmos.gov.v1.MsgSubmitProposal` - containing `/cosmos.mint.v1beta1.MsgUpdateParams` Implementation details: - add `MintParams` typing and mint params query plumbing - include mint parameters in the parameter-change form and keep `mint_denom` and `blocks_per_year` read-only while allowing editable inflation/goal values - resolve gov module authority dynamically from module account query - merge edited values with current on-chain mint params before submit so all required fields are present - encode LegacyDec fields in atomic 10^18 units for protobuf customtype compatibility (`0.003` -> `3000000000000000`) - preserve existing legacy parameter-change flow for non-mint subspaces - make mint query e2e assertions resilient to live-chain parameter drift - improve unknown-subspace errors with concise user-facing messaging Result: users can now submit working mint parameter governance proposals on Agoric networks that use gov-v1 MsgUpdateParams semantics.
Guard wallet connection when no network is selected. Previously, connect flow attempted to fetch network config with an undefined network name, producing requests like `https://undefined.agoric.net/network-config` and a no-op user experience. New behavior: - show a clear toast prompting network selection first - return early without attempting suggest-chain/connect
Commit editable table values when input focus is lost or editing context changes, not only on Enter/Save click. This makes parameter editing behave as users expect when tabbing between fields or clicking elsewhere in the form.
dckc
force-pushed
the
feat-issue-73-mint-params
branch
from
f35fa89 to
3a5060b
Compare
dckc
changed the title
Collaborator
Author
|
@kriskowal I lack magic powers to add to the requested reviewers list. Do you want to take a look? Do you want to nominate someone? This is in support of a proposal under discussion by the community, as noted in issue #73. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #73
This PR closes #73 by adding working mint-parameter governance updates in the Agoric flow.
User-visible behavior:
Mint Parameterssupport using the governance path required by current Agoric SDK/Cosmos SDK behavior.inflation_min,inflation_max,inflation_rate_change,goal_bonded.mint_denom,blocks_per_year.Validation run locally:
yarn lintyarn testyarn run build