Update TiGL to work with cpacs_tigl_gen Update #1083
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1083 +/- ##
==========================================
- Coverage 70.13% 69.91% -0.23%
==========================================
Files 307 294 -13
Lines 27601 27285 -316
==========================================
- Hits 19358 19075 -283
+ Misses 8243 8210 -33
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Nice to see that CPACSGen is improved, thanks :) Just a small comment from my side: In the |
I suggest setting it to the merge commit of the PR RISCSoftware/cpacs_tigl_gen#61, once merged. |
|
@merakulix, can we update this branch now that #1058 has been merged? This PR includes an update to the schema as well as some affected CPACS classes, see #1058 (comment). |
|
@merakulix, could you please
Then I will have another quick look, but then we should have it 💪 Thanks! |
|
Resolved all conflicts with the tanks update. Updated function names and ran python tests for fuel tanks again. Adjusted Python config file. All tests run successfully. |
|
Awesome! The drop in code coverage is expected, because the generated code is excluded from the metric and the ratio of generated code increases with this PR. |
This fixes an error that occurred in PR #1083. When updating the getter functions regarding const correctness, the decrement by 1 of the index was lost. Calling the base class getter functions fixes this, and reduces duplicate code.
This fixes an error that occurred in PR #1083. When updating the getter functions regarding const correctness, the decrement by 1 of the index was lost. Calling the base class getter functions fixes this, and reduces duplicate code. Co-authored-by: merakulix <82722016+merakulix@users.noreply.github.com>
TiGL is now up to date with the updates made in cpacs_tigl_gen that close Issue59 from RISCSoftware/cpacs_tigl_gen.
Description
The generator was updated to generate consistent getter functions for all CPACS Elements with Attribute: maxOccur = "unbounded".
This PR fixes conflicts that occured due to the changes.
Fixes Issue59 from RISCSoftware/cpacs_tigl_gen.
How Has This Been Tested?
Checklist: