Add LeadingEdgeDevices#1109
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1109 +/- ##
==========================================
- Coverage 72.75% 72.47% -0.28%
==========================================
Files 308 313 +5
Lines 26993 27391 +398
==========================================
+ Hits 19638 19851 +213
- Misses 7355 7540 +185
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@ole-alb I finally managed to look at the whole PR. Sorry it took so long. Apart from the comments above, I have two additional remarks:
|
|
Ok, I had another look and found a few small things, see above. Apart from this, there are still some open issues:
|
joergbrech
left a comment
There was a problem hiding this comment.
This looks good, and I don't want to change anything to this PR, now that it has a nice round number of 11000 changed lines 😉
There are a few things we can try to boost performance of the Boolean operations. We can change the way we perform the wing cutouts and run some benchmarks to see if it fixes anything. We can re-use the PaveFiller from the Boolean Operation that generates the LEDs in the Boolean operations for the wing cut outs. But this should be part of a separate PR.
On a final note, there is still the issue with the robustness of the Boolean operation that generates the LED, which caused the missing side caps. At the moment the best solution that we have right now is to introduce a small translational offset (1e-6) to the cutting tool used in the operation. This is not ideal, but we should definitely keep this in mind.
In TiGL 3 we only provide the implementation for TrailingEdgeDevices. This will be extended by LeadingEdgeDevices.
Closes #1101
Description
How Has This Been Tested?
Screenshots, that help to understand the changes(if applicable):
Checklist: