Skip to content

Added some utility functions for, and documentation about, trigger types used in integtests - #161

Merged
bieryAtFnal merged 29 commits into
developfrom
kbiery/integtest_trigger_choices
Jul 21, 2026
Merged

Added some utility functions for, and documentation about, trigger types used in integtests#161
bieryAtFnal merged 29 commits into
developfrom
kbiery/integtest_trigger_choices

Conversation

@bieryAtFnal

@bieryAtFnal bieryAtFnal commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Description

It is not always easy to determine which trigger type(s) are used in which integtests, nor how to specify the parameters for a given trigger type in a new integtest.

The changes in this PR attempt to help with that, and they provide several utility functions that can be used to enable Fake HSI triggers and/or set basic parameters associated with FakeHSI and/or RandomTriggerCandidateMaker triggers. This PR also include some preliminary documentation about which triggers are used in which integtests.

This PR is correlated with ones in several other repos:

To test these changes, the following steps can be used:

DATE_PREFIX=`date '+%d%b'`
TIME_SUFFIX=`date '+%H%M'`

source /cvmfs/dunedaq.opensciencegrid.org/setup_dunedaq.sh
setup_dbt latest
dbt-create -n NFD_DEV_260624_A9 ${DATE_PREFIX}FDDevIntegtestTriggerChoices_${TIME_SUFFIX}
cd ${DATE_PREFIX}FDDevIntegtestTriggerChoices_${TIME_SUFFIX}/sourcecode

git clone https://github.com/DUNE-DAQ/crtmodules.git -b kbiery/integtest_trigger_choices
git clone https://github.com/DUNE-DAQ/daqsystemtest.git -b kbiery/integtest_trigger_choices
git clone https://github.com/DUNE-DAQ/dfmodules.git -b kbiery/integtest_trigger_choices
git clone https://github.com/DUNE-DAQ/hsilibs.git -b develop
git clone https://github.com/DUNE-DAQ/listrev.git -b develop
git clone https://github.com/DUNE-DAQ/snbmodules.git -b develop
git clone https://github.com/DUNE-DAQ/trigger.git -b kbiery/integtest_trigger_choices
cd ..

cd pythoncode
git clone https://github.com/DUNE-DAQ/integrationtest.git -b kbiery/integtest_trigger_choices
cd ..

. ./env.sh
dbt-build -j 12
dbt-workarea-env

dunedaq_integtest_bundle.sh --verbosity 2 -r local --random 5

Type of change

  • Optimization (non-breaking change that improves code/performance)

Testing checklist

  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas

Kurt Biery and others added 23 commits May 23, 2026 11:51
Updated the survey document to include an introduction and a summary table for integration tests.
Updated the integtest documentation to include WIB counts and trigger rates for various tests.
Updated descriptions of trigger sources and their configurations in the integration tests documentation.

@MRiganSUSX MRiganSUSX left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bieryAtFnal,
Thanks for this updated, much cleaner, functionality.
I'm leaving several suggestions here and across the linked 5 PRs.

Don't think there are any glaring problems, some small style things and some places that could be tidied up.

Comment thread src/integrationtest/utility_functions.py Outdated
Comment thread src/integrationtest/utility_functions.py
Comment thread src/integrationtest/utility_functions.py Outdated
Comment thread src/integrationtest/utility_functions.py
Comment thread src/integrationtest/utility_functions.py
Comment thread src/integrationtest/utility_functions.py Outdated
Comment thread src/integrationtest/utility_functions.py Outdated
@@ -0,0 +1,75 @@
# Survey of trigger and readout window configurations that are used in existing integtests, Summer 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This documentation is GREAT.
My only concern is whether it makes sense to have the year in the filename instead (completely ok in the text), as updates later on can cause link breaks, or the file may look like it obsolete later on.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can discuss.
I put the date in the filename to try to make it very clear that it is a snapshot and may not be up-to-date at some point in the future...

Comment thread docs/SurveyOfTriggersUsedInIntegtestsSummer2026.md Outdated
Comment thread docs/SurveyOfTriggersUsedInIntegtestsSummer2026.md
Kurt Biery and others added 3 commits July 1, 2026 09:54
Updated integration test details for trigger rates and configurations, including specific parameters for WIB and DAPHNE data. Clarified expected rates and added observed rates for various tests.
@bieryAtFnal
bieryAtFnal requested a review from MRiganSUSX July 2, 2026 19:11

@MRiganSUSX MRiganSUSX left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the comments.

Passes the whole dunedaq_integtest_bundle.sh.

@bieryAtFnal
bieryAtFnal merged commit 7636160 into develop Jul 21, 2026
@bieryAtFnal
bieryAtFnal deleted the kbiery/integtest_trigger_choices branch July 21, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants