Added some utility functions for, and documentation about, trigger types used in integtests - #161
Conversation
Updated the survey document to include an introduction and a summary table for integration tests.
…formation in tables.
Updated the integtest documentation to include WIB counts and trigger rates for various tests.
…/DUNE-DAQ/integrationtest into kbiery/integtest_trigger_choices
Updated descriptions of trigger sources and their configurations in the integration tests documentation.
MRiganSUSX
left a comment
There was a problem hiding this comment.
Hi @bieryAtFnal,
Thanks for this updated, much cleaner, functionality.
I'm leaving several suggestions here and across the linked 5 PRs.
Don't think there are any glaring problems, some small style things and some places that could be tidied up.
| @@ -0,0 +1,75 @@ | |||
| # Survey of trigger and readout window configurations that are used in existing integtests, Summer 2026 | |||
There was a problem hiding this comment.
This documentation is GREAT.
My only concern is whether it makes sense to have the year in the filename instead (completely ok in the text), as updates later on can cause link breaks, or the file may look like it obsolete later on.
There was a problem hiding this comment.
We can discuss.
I put the date in the filename to try to make it very clear that it is a snapshot and may not be up-to-date at some point in the future...
Updated integration test details for trigger rates and configurations, including specific parameters for WIB and DAPHNE data. Clarified expected rates and added observed rates for various tests.
MRiganSUSX
left a comment
There was a problem hiding this comment.
Thank you for addressing the comments.
Passes the whole dunedaq_integtest_bundle.sh.
Description
It is not always easy to determine which trigger type(s) are used in which integtests, nor how to specify the parameters for a given trigger type in a new integtest.
The changes in this PR attempt to help with that, and they provide several utility functions that can be used to enable Fake HSI triggers and/or set basic parameters associated with FakeHSI and/or RandomTriggerCandidateMaker triggers. This PR also include some preliminary documentation about which triggers are used in which integtests.
This PR is correlated with ones in several other repos:
To test these changes, the following steps can be used:
Type of change
Testing checklist
dunedaq_integtest_bundle.sh)Further checks