-
Notifications
You must be signed in to change notification settings - Fork 2
Added some utility functions for, and documentation about, trigger types used in integtests #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
8d359a1
Started a document to list which triggers are used in which integtests.
c7f3e09
Revise Survey of Triggers in Integtests
bieryAtFnal aaed3a4
added more introduction and organized integtest-based config param in…
bieryAtFnal d1df5f3
minor changes
bieryAtFnal 27c61e3
Updated 3ru_1df information
bieryAtFnal 909c8bf
Enhance integtest documentation with WIB details
bieryAtFnal 324d151
Temporary file with functions that help to set trigger and readout wi…
eac283e
filled in MSQT and SFQT info
0682880
Update trigger rates and parameters in documentation
bieryAtFnal 8a09c46
Merge remote-tracking branch 'origin/develop' into kbiery/integtest_t…
289eb5f
Merge branch 'kbiery/integtest_trigger_choices' of https://github.com…
2d3328d
Merge remote-tracking branch 'origin/develop' into kbiery/integtest_t…
ad8ad1f
Merge remote-tracking branch 'origin/develop' into kbiery/integtest_t…
8d0adde
Merge remote-tracking branch 'origin/develop' into kbiery/integtest_t…
d84e1ee
Merged develop into kbiery/integtest_trigger_choices and removed
3181970
merged develop into kbiery/integtest_trigger_choices
70a555e
Updated survey document for June 2026
bieryAtFnal 78daf71
Updated trigger rates for trigger_bitwords_test.py
bieryAtFnal 693fe0c
Updated SurveyOfTriggersUsedInIntegtestsMay2026.md
c39a2b0
Refine trigger source descriptions in documentation
bieryAtFnal e49ea66
Updated SurveyOfTriggersUsedInIntegtestsMay2026.md
c429b16
Renamed the trigger summary doc
24fce0f
Renamed the trigger summary doc
1d93173
Made the changes to utility_functions.py suggested by Michal in PR #161.
a26c58d
Add trigger rate details for sample_ehn1_multihost_test
bieryAtFnal 053608d
First attempt at filling in triggers for dfmodules tests in the Surve…
bde350d
Revise integration test parameters and expected rates
bieryAtFnal 75d1071
Updated the trigger information for the remaining tests.
bieryAtFnal 12876da
Merge remote-tracking branch 'origin/develop' into kbiery/integtest_t…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| # Survey of trigger and readout window configurations that are used in existing integtests, Summer 2026 | ||
|
|
||
| ## Introduction | ||
|
|
||
| Here a list of the trigger sources that we typically use in integration/regression tests (and emulated-data running generally): | ||
|
|
||
| * **RandomTriggerCandidateMaker** | ||
| * This software module typically runs in the MLTApplication (along with the _MLTModule_ and the _DataHandlerModule_ that converts TriggerActivity objects into TriggerCandidate objects), and it receives TimeSync messages from the ReadoutApplications so that it knows what DTS (DUNE Timing System) timestamps are currently being processed by the emulated-data system. It has the ability to produce periodic triggers at a configurable rate, and it uses the knowledge of "detector time" that it gains from the TimeSync messages to provide a useful timestamp in the TriggerCandidate objects that it creates. | ||
| * Trigger records that are produced from these triggers have a TriggerCandidate type of _kRandom_ assigned to them. | ||
| * **FakeHSIEventGenerator** | ||
| * This software module typically runs in the FakeHSIApplication (along with the _HSIDataHandlerModule_), and it receives TimeSync messages from the ReadoutApplications so that it knows what DTS (DUNE Timing System) timestamps are currently being processed by the emulated-data system. It has the ability to produce periodic triggers at a configurable rate, and it uses the knowledge of "detector time" that it gains from the TimeSync messages to provide a useful timestamp in the TriggerCandidate objects that it creates. | ||
| * Trigger records that are produced from these triggers have a TriggerCandidate type of _kTiming_ assigned to them. | ||
| * **TriggerActivity and TriggerCandidate objects derived from TriggerPrimitives** | ||
| * The software modules that produce TAs and TCs run in the ReadoutApps, TriggerApps, and the MLT. | ||
| * In our integration tests, we have examples of creating TPs from WIB data and from DAPHNE data. | ||
| * For WIB data, we typically use a data-replay file that has all of the ADC values set to zero. We combine this with software (`SourceEmulatorModel`) that modifies every Nth ADC value to a large number, where N is configurable. In this way, we can set the rate of TPs to match the needs of the integration test. | ||
| * For DAPHNE data, we use a data-replay file taken from a particular run at EHN1. That file has some number of TPs in the data, and we tune parameters of the DAQ system to provide the desired TA and TC rates for a given integration test. | ||
| * In both cases, we configure the TA and TC makers to simply produce one output trigger object for every N input objects ("prescaling" the input messages). The baseline values for the TP->TA and TA->TC prescales are 1000 and 100, respectively. | ||
| * Trigger records that are produced from these triggers have a TriggerCandidate type of _kPrescale_ assigned to them. | ||
| * To calculate the expected rate of TP-based triggers from emulated WIB data, we multiply the number of emulated WIBs in the system by 64 (the number of channels per WIB), and multiply that value by 100 and the SourceEmu TP_rate parameter. The SourceEmulator code is designed to produce 100 Hz of TPs times its configured "rate" value. | ||
| * So, for 6 WIBs and a configured SourceEmu TP_rate of 1, the rate of TPs would be (6 * 64 * 100 * 1) = 38400. | ||
| * Dividing this number by TA and TC prescale values of 100 gives the expected rate of triggers, e.g. 38400 / 100 / 100 = 3.8 Hz. | ||
|
|
||
| The readout windows that are assigned to each trigger can be configured in the MLT or in modules that are upstream of that. | ||
|
|
||
| ## Configured trigger types, trigger rates, readout window widths, etc. | ||
|
|
||
| The tables in this section list the configuration parameters that are set for each of the integration tests. If an integtest uses more than one DUNE-DAQ configuration, the super-set of trigger types is listed. If a given test does not use a particular trigger type, nothing is listed. | ||
|
|
||
| To help save space in the table cells, the following abbreviations are used: | ||
|
|
||
| * RWBT - readout window begin ticks - this value determines the beginning of the readout window. It is added to the trigger time to determine the beginning of the readout window. Obviously, if this value is less than zero, the result is a timestamp that is earlier than the trigger time. | ||
| * RWET - readout window end ticks - this value determines the end of the readout window. It is added to the trigger time to determine the end of the readout window. | ||
| * RWW - readout window width, in either DTS clock ticks, wallclock time, or both. | ||
|
|
||
| ### Integtests in the _daqsystemtest_ repo: | ||
|
|
||
| | Integtest name | RTCM | FakeHSI | Triggers from TPs | | ||
| | --- | :---: | :---: | :---: | | ||
| | 3ru_1df_multirun_test.py | 1 Hz trigger rate, RWBT=-2000, RWET=5, RWW=32.1 usec | - | number of WIBs=9, SourceEmu TP_rate param=1, TAMakerPrescale=100, TCMakerPrescale=100, calculated 5.8 Hz, observed 5.5 Hz, RWBT=0, RWET=32, RWW=512 nsec | | ||
| | 3ru_3df_multirun_test.py | 3 Hz trigger rate, RWBT=-2000, RWET=5, RWW=32.1 usec | - | number of WIBs=6, SourceEmu TP_rate param=1, TAMakerPrescale=100, TCMakerPrescale=100, calculated 3.8 Hz, observed 3.6 Hz, RWBT=0, RWET=32, RWW=512 nsec | | ||
| | disabled_tpg_test.py | 1 Hz trigger rate, RWBT=-2000, RWET=5, RWW=32.1 usec | 3 Hz trigger rate, RWBT=-3000, RWET=1001, RWW=64.02 usec | - | | ||
| | example_system_test.py | 1 Hz trigger rate, RWBT=-2000, RWET=5, RWW=32.1 usec | 3 Hz trigger rate, RWBT=-3000, RWET=1001, RWW=64.02 usec | number of WIBs=4 or 8, SourceEmu TP_rate param=1, TAMakerPrescale=1000, TCMakerPrescale=100, observed 0.25 or 0.5 Hz, RWBT=0, RWET=32, RWW=512 nsec | | ||
| | fake_data_producer_test.py | 1 Hz trigger rate, RWBT=-2000, RWET=2001, RWW=64.02 usec | - | - | | ||
| | long_window_readout_test.py | 0.05 Hz trigger rate, RWBT=-100000000, RWET=1000000, RWW=1.62 sec | - | - | | ||
| | minimal_system_quick_test.py | 1 Hz trigger rate, RWBT=-2000, RWET=5, RWW=32.1 usec | - | - | | ||
| | readout_type_scan_test.py | 1 Hz trigger rate, various readout window widths | - | various rates and readout window widths | | ||
| | sample_ehn1_multihost_test.py | 1 Hz trigger rate, RWBT=-2000, RWET=5, RWW=32.1 usec | 3 Hz trigger rate, RWBT=-3000, RWET=1001, RWW=64.02 usec | number of WIBs=4, SourceEmu TP_rate param=1, TAMakerPrescale=1000, TCMakerPrescale=100, observed 0.25 Hz, RWBT=0, RWET=32, RWW=512 nsec | | ||
| | small_footprint_quick_test.py | - | 1 Hz trigger rate, RWBT=-3000, RWET=1001, RWW=64.02 usec | - | | ||
| | tpg_state_collection_test.py | 1 Hz trigger rate, RWBT=-2000, RWET=5, RWW=32.1 usec | - | - | | ||
| | tpreplay_test.py | 0 Hz | - | - | | ||
| | tpstream_writing_test.py | 1 Hz trigger rate, RWBT=-2000, RWET=5, RWW=32.1 usec | - | number of WIBs=2, SourceEmu TP_rate param=1, TAMakerPrescale=25, TCMakerPrescale=100, calculated 5.1 Hz, observed 4.9 Hz, RWBT=0, RWET=32, RWW=512 nsec | | ||
| | trigger_bitwords_test.py | typical rate and readout window plus 40 Hz trigger rate, RWBT=-62500, RWET=62500 | typical rates and readout window plus 30 Hz trigger rate, RWBT=-62500, RWET=62500 | - | | ||
|
|
||
| ### Integtests in the _dfmodules_ repo: | ||
|
|
||
| | Integtest name | RTCM | FakeHSI | Triggers from TPs | | ||
| | --- | :---: | :---: | :---: | | ||
| | disabled_output_test.py | 1 Hz trigger rate, RWBT=-2000, RWET=5, RWW=32.1 usec | - | number of WIBs=2, SourceEmu TP_rate param=1, TAMakerPrescale=25, TCMakerPrescale=100, calculated 5.1 Hz, observed 4.9 Hz, RWBT=0, RWET=32, RWW=512 nsec | | ||
| | hdf5_compression_test.py| - | 10 Hz trigger rate, RWBT=-120000, RWET=1000, RWW=1.94 msec | number of emulated DAPHNE cards=6, DAPHNE replay data from run 36012, TAMakerPrescale=2000, TCMakerPrescale=100, observed ~2.1 Hz, RWBT=0, RWET=3040, RWW=48.6 usec | | ||
| | insufficient_disk_space_test.py | 0.2 Hz trigger rate, RWBT=-9000000, RWET=1000000, RWW=160 msec | - | - | | ||
| | large_trigger_record_test.py | 0.06 Hz trigger rate, RWBT=-10000000 or -25000000, RWET=1000000, RWW=176 or 416 msec | - | - | | ||
| | max_file_size_test.py | - | 10 Hz trigger rate, RWBT=-52000, RWET=1000, RWW=848 usec | number of WIBs=6, SourceEmu TP_rate param=5, TAMakerPrescale=1000, TCMakerPrescale=100, calculated 1.92 Hz, observed 1.84 Hz, RWBT=0, RWET=32, RWW=512 nsec | | ||
| | multiple_data_writers_test.py | - | 10 Hz trigger rate, RWBT=-52000, RWET=1000, RWW=848 usec | - | | ||
| | offline_prod_run_test.py | - | 1 Hz trigger rate, RWBT=-3000, RWET=1001, RWW=64.02 usec | - | | ||
| | trmonrequestor_test.py | 1 Hz trigger rate, RWBT=-2000, RWET=5, RWW=32.1 usec | - | - | | ||
|
|
||
| ### Other integtests: | ||
|
|
||
| | Integtest name | RTCM | FakeHSI | Triggers from TPs | | ||
|
MRiganSUSX marked this conversation as resolved.
|
||
| | --- | :---: | :---: | :---: | | ||
| | crtmodules/crt_frame_builder_test.py | 1 Hz trigger rate, RWBT=-2000, RWET=5, RWW=32.1 usec | 3 Hz trigger rate, RWBT=-3000, RWET=1001, RWW=64.02 usec | - | | ||
| | hsilibs/iceberg_real_hsi_test.py | this test needs to be updated for v5 configurations | | | | ||
| | listrev/listrev_test.py | this test does not use DUNE DAQ triggers | | | | ||
| | snbmodules/simple_transform_test.py | - | - | this test appears to use an SNB trigger (kSupernova) with RWBT=0, RWET=200704, RWW=3.2 msec | | ||
| | trigger/change_rate_test.py | 2, 1, 0.1, and 0.01 Hz trigger rates, RWBT=-1000, RWET=1001, RWW=32 usec | - | - | | ||
This file was deleted.
Oops, something went wrong.
Empty file.
Empty file.
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This documentation is GREAT.
My only concern is whether it makes sense to have the year in the filename instead (completely ok in the text), as updates later on can cause link breaks, or the file may look like it obsolete later on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can discuss.
I put the date in the filename to try to make it very clear that it is a snapshot and may not be up-to-date at some point in the future...