Disable noisy auto-approve and auto-merge workflows (manual-only during review phase) - #104
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e4c26fbd9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - "!.github/workflows/auto-approve.yml" | ||
| pull_request_review: | ||
| types: [dismissed] | ||
| workflow_dispatch: |
There was a problem hiding this comment.
Switching this workflow to workflow_dispatch removes the pull_request payload, but the jobs still depend on github.event.pull_request.number (for policy-gate.ts, gh pr checks, gh pr review, and gh pr merge). When run manually, PR_NUMBER is empty and the workflow cannot perform approval/merge actions, so it is no longer usable in the advertised “manual runs only” mode.
Useful? React with 👍 / 👎.
| on: | ||
| pull_request: | ||
| types: [opened, reopened, synchronize, ready_for_review, labeled] | ||
| workflow_dispatch: |
There was a problem hiding this comment.
Using workflow_dispatch here drops github.event.pull_request from the event payload, but this workflow still reads github.event.pull_request.labels and passes github.event.pull_request.number to enable-pull-request-automerge. In manual runs those fields are missing, so the label gate and merge step cannot target a PR, breaking the intended manual fallback behavior.
Useful? React with 👍 / 👎.
1 participant
Motivation
auto-approveandauto-mergeworkflows that run and report "No jobs were run" while keeping the workflow files in place for manual use and future re-enabling.Description
.github/workflows/auto-approve.ymltoworkflow_dispatchand added a top comment stating the workflow is disabled during the controlled-demo/manual-merge phase..github/workflows/auto-merge.ymltoworkflow_dispatchand added the same explanatory top comment.docs/KNOWN_ISSUES.mdnoting that auto-approve/auto-merge are intentionally disabled and should be re-enabled only after branch protection, labels, and permissions are reviewed.Testing
git diff --checkwith no issues reported.npm run lint(ESLint completed successfully; npm emitted a non-fatal warning about an unknown env confighttp-proxy).Codex Task