Conversation
DatadogAgentDatadogAgent
| tracer_signature_(tracer_signature), | ||
| integration_name_(integration_name), | ||
| integration_version_(integration_version), | ||
| user_metrics_(user_metrics) { |
There was a problem hiding this comment.
nit: Can now remove user_metrics_ from tracer_telemetry.h
There was a problem hiding this comment.
That's a mistake, thank you for raising this. Addressed in b493cee
dubloom
left a comment
There was a problem hiding this comment.
This PR introduces a coupling between tracer_telemetry and telemetry which does not seem standard in comparison with the other tracers. Is there any objective or removing the tracer_telemetry later ? I would personally prefer if everything was centralized.
BenchmarksBenchmark execution time: 2025-04-03 09:49:11 Comparing candidate commit 56ddaaf in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 0 metrics, 0 unstable metrics. scenario:BM_TraceTinyCCSource
|
|
@dubloom the coupling in temporary. While we aim for standardization and feature parity, only public facing code and API are bound by that requirement. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
==========================================
+ Coverage 93.15% 93.38% +0.22%
==========================================
Files 76 78 +2
Lines 4471 4487 +16
==========================================
+ Hits 4165 4190 +25
+ Misses 306 297 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This PR continues the work of refactoring the telemetry module to provide a clear and structured telemetry API. The goal is to make it easier for Datadog engineers to collect telemetry metrics and logs on the usage of our products.
Specifically, this PR moves the telemetry logic out of
DatadogAgentand into a the telemetry module.For reference, Part 1 of this refactoring can be found here: #166.