Conversation
BenchmarksBenchmark execution time: 2025-04-03 10:18:20 Comparing candidate commit c9e8d1b in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. |
|
Hello there, I will review the 3 PRs on telemetry tomorrow morning ! |
dubloom
left a comment
There was a problem hiding this comment.
LGTM, I made suggestion mainly about having one function with optional stacktrace everywhere but I'm still good if you don't want to do that.
b37bfdc to
36a0cd6
Compare
Changes: - Add unit tests. - Report `stack_trace` and `timestamp`.
10e7364 to
c9e8d1b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
==========================================
+ Coverage 90.30% 90.81% +0.51%
==========================================
Files 80 81 +1
Lines 4621 4651 +30
==========================================
+ Hits 4173 4224 +51
+ Misses 448 427 -21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Fix telemetry logs and add support for stacktrace reporting.
Changes:
stack_traceandtimestamp.