Skip to content

[part 4] fix(telemetry): report logs#199

Merged
dmehala merged 1 commit intomainfrom
dmehala/telemetry/part-4-logs
Apr 3, 2025
Merged

[part 4] fix(telemetry): report logs#199
dmehala merged 1 commit intomainfrom
dmehala/telemetry/part-4-logs

Conversation

@dmehala
Copy link
Copy Markdown
Collaborator

@dmehala dmehala commented Apr 1, 2025

Description

Fix telemetry logs and add support for stacktrace reporting.

Changes:

  • Add unit tests.
  • Report stack_trace and timestamp.

@dmehala dmehala requested a review from a team as a code owner April 1, 2025 14:33
@dmehala dmehala requested review from cataphract, dubloom, pablomartinezbernardo and zacharycmontoya and removed request for a team April 1, 2025 14:33
@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Apr 1, 2025

Benchmarks

Benchmark execution time: 2025-04-03 10:18:20

Comparing candidate commit c9e8d1b in PR branch dmehala/telemetry/part-4-logs with baseline commit c6ca2f0 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@dubloom
Copy link
Copy Markdown
Contributor

dubloom commented Apr 1, 2025

Hello there, I will review the 3 PRs on telemetry tomorrow morning !

Copy link
Copy Markdown
Contributor

@dubloom dubloom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I made suggestion mainly about having one function with optional stacktrace everywhere but I'm still good if you don't want to do that.

@dmehala dmehala force-pushed the dmehala/telemetry/part-3-introduce-singleton branch from b37bfdc to 36a0cd6 Compare April 3, 2025 09:59
Base automatically changed from dmehala/telemetry/part-3-introduce-singleton to main April 3, 2025 10:13
Changes:
 - Add unit tests.
 - Report `stack_trace` and `timestamp`.
@dmehala dmehala force-pushed the dmehala/telemetry/part-4-logs branch from 10e7364 to c9e8d1b Compare April 3, 2025 10:15
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 70.58824% with 10 lines in your changes missing coverage. Please review.

Project coverage is 90.81%. Comparing base (c6ca2f0) to head (c9e8d1b).

Files with missing lines Patch % Lines
src/datadog/telemetry/telemetry.cpp 0.00% 8 Missing ⚠️
src/datadog/telemetry/log.h 85.71% 1 Missing ⚠️
src/datadog/tracer_telemetry.cpp 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
+ Coverage   90.30%   90.81%   +0.51%     
==========================================
  Files          80       81       +1     
  Lines        4621     4651      +30     
==========================================
+ Hits         4173     4224      +51     
+ Misses        448      427      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmehala dmehala merged commit 18afd17 into main Apr 3, 2025
22 checks passed
@dmehala dmehala deleted the dmehala/telemetry/part-4-logs branch April 3, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants