Conversation
dmehala
requested review from
cataphract,
dubloom,
pablomartinezbernardo and
wdhif
and removed request for
a team
| result.metadata[ConfigName::AGENT_URL] = | ||
| ConfigMetadata(ConfigName::AGENT_URL, url, origin); | ||
|
|
||
| /// Starting Agent X, the admission controller inject a unique identifier |
There was a problem hiding this comment.
- find the datadog agent version
Datadog Summary✅ Code Quality ✅ Code Security ✅ Dependencies Was this helpful? Give us feedback! |
Origin Detection allows to detect where the contaienr traces come from, and add container tags automatically to the local root span.
dmehala
force-pushed
the
dmehala/origin-detection
branch
from
462041e to
fdb6393
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
==========================================
- Coverage 87.02% 86.79% -0.23%
==========================================
Files 80 80
Lines 5140 5210 +70
==========================================
+ Hits 4473 4522 +49
- Misses 667 688 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dubloom
left a comment
dubloom
left a comment
There was a problem hiding this comment.
Most of my comments are nit/picky ones.
However there is one env variable that is not set according to the specifications.
| } | ||
| }, | ||
| { | ||
| "name": "dev", |
There was a problem hiding this comment.
I will be annoying but that would be cool to add documentation somewhere on how to use that (if it is supposed to be used by devs).
It does not need to be in that PR.
Co-authored-by: Louis Tricot <75956635+dubloom@users.noreply.github.com>
| #endif | ||
| } // namespace | ||
|
|
||
| Optional<std::string> find_docker_container_id(std::istream& source) { |
There was a problem hiding this comment.
| Optional<std::string> find_docker_container_id(std::istream& source) { | |
| // this function only exists for testing purposes | |
| Optional<std::string> find_docker_container_id(std::istream& source) { |
There was a problem hiding this comment.
That's litterally mentionned in the header file:
dd-trace-cpp/src/datadog/platform_util.h
Line 88 in 29f6a50
4 participants
Description
Origin Detection allows to detect where the contaienr traces come from, and add container tags automatically to the local root span.
Resolves #193
Motivation
Feature request #193
Additional Notes
Jira ticket: APMAPI-1404