Skip to content

Enable Process Discovery tests for Node.js#6638

Merged
tlhunter merged 3 commits intomainfrom
enable-process-tags-nodejs
Mar 27, 2026
Merged

Enable Process Discovery tests for Node.js#6638
tlhunter merged 3 commits intomainfrom
enable-process-tags-nodejs

Conversation

@wantsui
Copy link
Copy Markdown
Contributor

@wantsui wantsui commented Mar 27, 2026

Motivation

Flips the process discovery tests on for Node.js
https://github.com/DataDog/dd-trace-js/releases/tag/v5.93.0

[da201ffe61] - (SEMVER-MINOR) feat(process-discovery): include process_tags and container_id, disable crashtracker ARM64 musl (Thomas Hunter II) DataDog/dd-trace-js#7816
[a498993115] - (SEMVER-MINOR) feat(config): enable process tags by default (Thomas Hunter II) DataDog/dd-trace-js#7850

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@wantsui wantsui requested a review from tlhunter March 27, 2026 19:09
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2026

CODEOWNERS have been resolved as:

manifests/nodejs.yml                                                    @DataDog/dd-trace-js
tests/parametric/test_process_discovery.py                              @DataDog/system-tests-core @DataDog/apm-sdk-capabilities

@datadog-official
Copy link
Copy Markdown

datadog-official bot commented Mar 27, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c8ac1a3 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@tlhunter tlhunter marked this pull request as ready for review March 27, 2026 21:48
@tlhunter tlhunter requested review from a team as code owners March 27, 2026 21:48
@tlhunter tlhunter requested review from BridgeAR and removed request for a team March 27, 2026 21:48
@tlhunter tlhunter merged commit d0050bf into main Mar 27, 2026
448 checks passed
@tlhunter tlhunter deleted the enable-process-tags-nodejs branch March 27, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants