Skip to content

Enable Process Discovery tests for Node.js #6638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlhunter merged 3 commits into from
Mar 27, 2026
+5 −1
Merged

Enable Process Discovery tests for Node.js #6638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1f1929
Enable process discovery tests for nodejs
wantsui Mar 27, 2026
5110575
make node parametric process PID=1 to fix memfs failure
tlhunter Mar 27, 2026
c8ac1a3
no longer use node as pid=1 since it might break crashtracking
tlhunter Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2057,7 +2057,7 @@ manifest:
tests/parametric/test_parametric_endpoints.py::Test_Parametric_Otel_Current_Span: incomplete_test_app (otel current_span endpoint is not supported)
tests/parametric/test_parametric_endpoints.py::Test_Parametric_Write_Log: *ref_5_72_0
tests/parametric/test_partial_flushing.py::Test_Partial_Flushing: bug (APMLP-270)
tests/parametric/test_process_discovery.py: missing_feature
tests/parametric/test_process_discovery.py::Test_ProcessDiscovery: v5.93.0
tests/parametric/test_sampling_manual.py::Test_Manual_Sampling: bug (APMAPI-1720) # Manual keep did not override the upstream drop decision
tests/parametric/test_sampling_span_tags.py::Test_Knuth_Sample_Rate: missing_feature
tests/parametric/test_sampling_span_tags.py::Test_Sampling_Span_Tags::test_tags_appsec_enabled_sst011: bug (APMAPI-737)
Expand Down
4 changes: 4 additions & 0 deletions tests/parametric/test_process_discovery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,10 @@ def assert_metadata_content(test_library: APMLibrary, library_env: dict[str, str
rc, out = test_library.container_exec_run("pidof java")
assert rc
pid = int(out)
elif context.library.name == "nodejs":
rc, out = test_library.container_exec_run("pidof node")
assert rc
pid = int(out)
memfds = find_dd_memfds(test_library, pid)
assert len(memfds) == 1
rc, tracer_metadata = read_memfd(test_library, memfds[0])
Expand Down
Loading