Conversation
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0deeae24c3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| assert root_span is not None, "Root span not found" | ||
| assert "_dd.svc_src" not in root_span.get("meta", {}) | ||
|
|
||
| def test_tracer_srv_src_inherited_on_child_span(self, test_agent: TestAgentAPI, test_library: APMLibrary) -> None: |
There was a problem hiding this comment.
Add manifest gating for new service-source inheritance test
This new parametric test is introduced without corresponding manifest declarations, so it will run by default on every library/version, including ones where this feature is explicitly marked unsupported for sibling tests in the same class (for example manifests/python.yml:1800-1801, manifests/nodejs.yml:2130-2131, manifests/ruby.yml:1557-1558, manifests/cpp.yml:290-291). In this repo, manifest rules control activation/deactivation at collection time (conftest.py::pytest_collection_modifyitems), so missing entries here can cause broad CI regressions outside Java/.NET/Golang support windows.
Useful? React with 👍 / 👎.
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 003d0b7 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
pabloerhard
left a comment
There was a problem hiding this comment.
Wasn't this behavior something we only wanted for tracers in which spans inherit service name from their parent spans?
no worries, in this case, like for other tests, we can use |
Motivation
Add a parametric test to ensure that, when a child span is opened without setting any service name, it inherits the service source from the parent
I also simplified the manifest and marked as a bug (with the related jira) for dotnet
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present