Skip to content

Ensure that _dd.srv_src is inherited #6642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amarziali wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Ensure that _dd.srv_src is inherited #6642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0deeae2
Ensure that _dd.srv_src is inherited
amarziali Mar 30, 2026
9b2e7e4
Adjust manifests
amarziali Mar 30, 2026
003d0b7
adjust go manifest
amarziali Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions manifests/cpp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,8 +287,7 @@ manifest:
tests/parametric/test_tracer.py::Test_Tracer::test_tracer_span_top_level_attributes: missing_feature (metrics cannot be set manually)
tests/parametric/test_tracer.py::Test_TracerBaseService: missing_feature (_dd.base_service is not implemented)
tests/parametric/test_tracer.py::Test_TracerSCITagging: missing_feature
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_manual_service_name_sets_srv_src: irrelevant (Only implemented for Java)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_no_srv_src_when_service_not_manually_set: irrelevant (Only implemented for Java)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource: irrelevant
tests/parametric/test_tracer.py::Test_TracerUniversalServiceTagging::test_tracer_service_name_environment_variable: "missing_feature (FIXME: library test client sets empty string as the service name)"
tests/parametric/test_tracer_flare.py: '>=2.0.0' # Modified by easy win activation script
tests/parametric/test_tracer_flare.py::TestTracerFlareV1::test_flare_log_level_order: missing_feature # Created by easy win activation script
Expand Down
3 changes: 1 addition & 2 deletions manifests/cpp_httpd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,7 @@ manifest:
tests/parametric/test_telemetry.py::Test_TelemetrySCAEnvVar::test_telemetry_sca_enabled_propagated_specifics: irrelevant
tests/parametric/test_tracer.py::Test_ProcessTags_ServiceName: missing_feature
tests/parametric/test_tracer.py::Test_TracerBaseService: missing_feature (_dd.base_service is not implemented)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_manual_service_name_sets_srv_src: irrelevant (Only implemented for Java)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_no_srv_src_when_service_not_manually_set: irrelevant (Only implemented for Java)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource: irrelevant
tests/parametric/test_tracer.py::Test_TracerUniversalServiceTagging::test_tracer_service_name_environment_variable: "missing_feature (FIXME: library test client sets empty string as the service name)"
tests/remote_config/test_remote_configuration.py::Test_RemoteConfigurationExtraServices: missing_feature
tests/remote_config/test_remote_configuration.py::Test_RemoteConfigurationUpdateSequenceASMDD: missing_feature
Expand Down
3 changes: 1 addition & 2 deletions manifests/cpp_nginx.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,8 +306,7 @@ manifest:
tests/parametric/test_telemetry.py::Test_TelemetrySCAEnvVar::test_telemetry_sca_enabled_propagated_specifics: irrelevant
tests/parametric/test_tracer.py::Test_ProcessTags_ServiceName: missing_feature
tests/parametric/test_tracer.py::Test_TracerBaseService: missing_feature (_dd.base_service is not implemented)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_manual_service_name_sets_srv_src: irrelevant (Only implemented for Java)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_no_srv_src_when_service_not_manually_set: irrelevant (Only implemented for Java)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource: irrelevant
tests/parametric/test_tracer.py::Test_TracerUniversalServiceTagging::test_tracer_service_name_environment_variable: "missing_feature (FIXME: library test client sets empty string as the service name)"
tests/remote_config/test_remote_configuration.py::Test_RemoteConfigurationExtraServices: missing_feature
tests/remote_config/test_remote_configuration.py::Test_RemoteConfigurationUpdateSequenceASMDD: v1.3.0
Expand Down
1 change: 1 addition & 0 deletions manifests/dotnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1014,6 +1014,7 @@ manifest:
tests/parametric/test_tracer.py::Test_TracerSCITagging: v2.48.0
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_manual_service_name_sets_srv_src: v3.40.0
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_no_srv_src_when_service_not_manually_set: v3.40.0
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_srv_src_inherited_on_child_span: bug (APMLP-1227)
tests/parametric/test_tracer.py::Test_TracerUniversalServiceTagging::test_tracer_service_name_environment_variable: "missing_feature (FIXME: library test client sets empty string as the service name)"
tests/parametric/test_tracer_flare.py::TestTracerFlareV1: v2.48.0
tests/remote_config/test_remote_configuration.py::Test_RemoteConfigurationExtraServices: v2.36.0
Expand Down
1 change: 1 addition & 0 deletions manifests/golang.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1203,6 +1203,7 @@ manifest:
tests/parametric/test_tracer.py::Test_TracerSCITagging: v1.48.0
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_manual_service_name_sets_srv_src: irrelevant (Only implemented for Java)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_no_srv_src_when_service_not_manually_set: '>=2.7.0-dev.1'
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_srv_src_inherited_on_child_span: v2.9.0-dev
tests/parametric/test_tracer.py::Test_TracerUniversalServiceTagging::test_tracer_service_name_environment_variable: "missing_feature (FIXME: library test client sets empty string as the service name)"
tests/parametric/test_tracer_flare.py::TestTracerFlareV1: '>=2.5.0' # Modified by easy win activation script
tests/parametric/test_tracer_flare.py::TestTracerFlareV1::test_flare_log_level_order: missing_feature # Created by easy win activation script
Expand Down
3 changes: 1 addition & 2 deletions manifests/java_otel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,7 @@ manifest:
tests/parametric/test_span_sampling.py::Test_Span_Sampling::test_keep_span_with_stats_computation_sss010: missing_feature (this has to be implemented by a lot of the tracers and we need to do a bit of work on the assert)
tests/parametric/test_telemetry.py::Test_TelemetrySCAEnvVar::test_telemetry_sca_enabled_propagated_specifics: irrelevant
tests/parametric/test_tracer.py::Test_ProcessTags_ServiceName: missing_feature
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_manual_service_name_sets_srv_src: irrelevant (Only implemented for Java)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_no_srv_src_when_service_not_manually_set: irrelevant (Only implemented for Java)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource: irrelevant
tests/parametric/test_tracer.py::Test_TracerUniversalServiceTagging::test_tracer_service_name_environment_variable: "missing_feature (FIXME: library test client sets empty string as the service name)"
tests/stats/test_stats.py::Test_Stats_Service_Source: irrelevant (Only implemented for Java)
tests/test_library_conf.py::Test_HeaderTags_DynamicConfig::test_tracing_client_http_header_tags_apm_multiconfig: missing_feature (APM_TRACING_MULTICONFIG is not supported in any language yet)
Expand Down
3 changes: 1 addition & 2 deletions manifests/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2127,8 +2127,7 @@ manifest:
tests/parametric/test_tracer.py::Test_Tracer::test_tracer_span_top_level_attributes: missing_feature (nodejs overrides the manually set service name)
tests/parametric/test_tracer.py::Test_TracerSCITagging: *ref_3_21_0
tests/parametric/test_tracer.py::Test_TracerSCITagging::test_tracer_repository_url_strip_credentials: missing_feature (nodejs does not strip credentials yet)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_manual_service_name_sets_srv_src: irrelevant (Only implemented for Java)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_no_srv_src_when_service_not_manually_set: irrelevant (Only implemented for Java)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource: irrelevant
tests/parametric/test_tracer.py::Test_TracerUniversalServiceTagging::test_tracer_service_name_environment_variable: "missing_feature (FIXME: library test client sets empty string as the service name)"
tests/parametric/test_tracer_flare.py::TestTracerFlareV1: *ref_5_15_0
tests/parametric/test_tracer_flare.py::TestTracerFlareV1::test_tracer_flare: missing_feature (Only plaintext files are sent presently)
Expand Down
3 changes: 1 addition & 2 deletions manifests/nodejs_otel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,7 @@ manifest:
tests/parametric/test_span_sampling.py::Test_Span_Sampling::test_keep_span_with_stats_computation_sss010: missing_feature (this has to be implemented by a lot of the tracers and we need to do a bit of work on the assert)
tests/parametric/test_telemetry.py::Test_TelemetrySCAEnvVar::test_telemetry_sca_enabled_propagated_specifics: irrelevant
tests/parametric/test_tracer.py::Test_ProcessTags_ServiceName: missing_feature
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_manual_service_name_sets_srv_src: irrelevant (Only implemented for Java)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_no_srv_src_when_service_not_manually_set: irrelevant (Only implemented for Java)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource: irrelevant
tests/parametric/test_tracer.py::Test_TracerUniversalServiceTagging::test_tracer_service_name_environment_variable: "missing_feature (FIXME: library test client sets empty string as the service name)"
tests/stats/test_stats.py::Test_Stats_Service_Source: irrelevant (Only implemented for Java)
tests/test_library_conf.py::Test_HeaderTags_DynamicConfig::test_tracing_client_http_header_tags_apm_multiconfig: missing_feature (APM_TRACING_MULTICONFIG is not supported in any language yet)
Expand Down
3 changes: 1 addition & 2 deletions manifests/php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,8 +859,7 @@ manifest:
tests/parametric/test_trace_sampling.py::Test_Trace_Sampling_With_W3C: missing_feature
tests/parametric/test_tracer.py::Test_ProcessTags_ServiceName: missing_feature
tests/parametric/test_tracer.py::Test_TracerSCITagging: v1.2.0
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_manual_service_name_sets_srv_src: irrelevant (Only implemented for Java)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_no_srv_src_when_service_not_manually_set: irrelevant (Only implemented for Java)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource: irrelevant
tests/parametric/test_tracer.py::Test_TracerUniversalServiceTagging::test_tracer_service_name_environment_variable: "missing_feature (FIXME: library test client sets empty string as the service name)"
tests/parametric/test_tracer_flare.py::TestTracerFlareV1: missing_feature
tests/parametric/test_tracer_flare.py::TestTracerFlareV1::test_flare_log_level_order: '>=1.16.0'
Expand Down
3 changes: 1 addition & 2 deletions manifests/python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1797,8 +1797,7 @@ manifest:
tests/parametric/test_tracer.py::Test_ProcessTags_ServiceName: v4.7.0
tests/parametric/test_tracer.py::Test_Tracer: v2.8.0
tests/parametric/test_tracer.py::Test_TracerSCITagging: v1.12.0
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_manual_service_name_sets_srv_src: irrelevant (Only implemented for Java)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_no_srv_src_when_service_not_manually_set: irrelevant (Only implemented for Java)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource: irrelevant
tests/parametric/test_tracer.py::Test_TracerUniversalServiceTagging: v0.36.0
tests/parametric/test_tracer.py::Test_TracerUniversalServiceTagging::test_tracer_service_name_environment_variable: "missing_feature (FIXME: library test client sets empty string as the service name)"
tests/parametric/test_tracer_flare.py::TestTracerFlareV1: v3.12.0.dev
Expand Down
3 changes: 1 addition & 2 deletions manifests/python_lambda.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,8 +317,7 @@ manifest:
tests/parametric/test_span_sampling.py::Test_Span_Sampling::test_keep_span_with_stats_computation_sss010: missing_feature (this has to be implemented by a lot of the tracers and we need to do a bit of work on the assert)
tests/parametric/test_telemetry.py::Test_TelemetrySCAEnvVar::test_telemetry_sca_enabled_propagated_specifics: irrelevant
tests/parametric/test_tracer.py::Test_ProcessTags_ServiceName: missing_feature
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_manual_service_name_sets_srv_src: irrelevant (Only implemented for Java)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_no_srv_src_when_service_not_manually_set: irrelevant (Only implemented for Java)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource: irrelevant
tests/parametric/test_tracer.py::Test_TracerUniversalServiceTagging::test_tracer_service_name_environment_variable: "missing_feature (FIXME: library test client sets empty string as the service name)"
tests/stats/test_stats.py::Test_Stats_Service_Source: irrelevant (Only implemented for Java)
tests/test_library_conf.py::Test_HeaderTags_DynamicConfig::test_tracing_client_http_header_tags_apm_multiconfig: missing_feature (APM_TRACING_MULTICONFIG is not supported in any language yet)
Expand Down
3 changes: 1 addition & 2 deletions manifests/python_otel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,7 @@ manifest:
tests/parametric/test_span_sampling.py::Test_Span_Sampling::test_keep_span_with_stats_computation_sss010: missing_feature (this has to be implemented by a lot of the tracers and we need to do a bit of work on the assert)
tests/parametric/test_telemetry.py::Test_TelemetrySCAEnvVar::test_telemetry_sca_enabled_propagated_specifics: irrelevant
tests/parametric/test_tracer.py::Test_ProcessTags_ServiceName: missing_feature
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_manual_service_name_sets_srv_src: irrelevant (Only implemented for Java)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_no_srv_src_when_service_not_manually_set: irrelevant (Only implemented for Java)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource: irrelevant
tests/parametric/test_tracer.py::Test_TracerUniversalServiceTagging::test_tracer_service_name_environment_variable: "missing_feature (FIXME: library test client sets empty string as the service name)"
tests/stats/test_stats.py::Test_Stats_Service_Source: irrelevant (Only implemented for Java)
tests/test_library_conf.py::Test_HeaderTags_DynamicConfig::test_tracing_client_http_header_tags_apm_multiconfig: missing_feature (APM_TRACING_MULTICONFIG is not supported in any language yet)
Expand Down
3 changes: 1 addition & 2 deletions manifests/ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1554,8 +1554,7 @@ manifest:
tests/parametric/test_tracer.py::Test_ProcessTags_ServiceName: missing_feature
tests/parametric/test_tracer.py::Test_TracerBaseService: missing_feature (_dd.base_service is not implemented)
tests/parametric/test_tracer.py::Test_TracerSCITagging: v1.21.0
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_manual_service_name_sets_srv_src: irrelevant (Only implemented for Java)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_no_srv_src_when_service_not_manually_set: irrelevant (Only implemented for Java)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource: irrelevant
tests/parametric/test_tracer.py::Test_TracerUniversalServiceTagging::test_tracer_service_name_environment_variable: "missing_feature (FIXME: library test client sets empty string as the service name)"
tests/parametric/test_tracer_flare.py::TestTracerFlareV1: '>=2.27.0' # Modified by easy win activation script
tests/parametric/test_tracer_flare.py::TestTracerFlareV1::test_flare_log_level_order: missing_feature # Created by easy win activation script
Expand Down
3 changes: 1 addition & 2 deletions manifests/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,8 +292,7 @@ manifest:
tests/parametric/test_tracer.py::Test_Tracer: missing_feature # Created by easy win activation script
tests/parametric/test_tracer.py::Test_TracerBaseService: missing_feature (_dd.base_service is not implemented)
tests/parametric/test_tracer.py::Test_TracerSCITagging: missing_feature # Created by easy win activation script
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_manual_service_name_sets_srv_src: irrelevant (Only implemented for Java)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_no_srv_src_when_service_not_manually_set: irrelevant (Only implemented for Java)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource: irrelevant
tests/parametric/test_tracer.py::Test_TracerUniversalServiceTagging::test_tracer_service_name_environment_variable: "missing_feature (FIXME: library test client sets empty string as the service name)"
tests/parametric/test_tracer_flare.py::TestTracerFlareV1: '>=0.2.1' # Modified by easy win activation script
tests/parametric/test_tracer_flare.py::TestTracerFlareV1::test_flare_log_level_order: missing_feature # Created by easy win activation script
Expand Down
19 changes: 19 additions & 0 deletions tests/parametric/test_tracer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,25 @@ def test_tracer_no_srv_src_when_service_not_manually_set(
assert root_span is not None, "Root span not found"
assert "_dd.svc_src" not in root_span.get("meta", {})

def test_tracer_srv_src_inherited_on_child_span(self, test_agent: TestAgentAPI, test_library: APMLibrary) -> None:
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add manifest gating for new service-source inheritance test

This new parametric test is introduced without corresponding manifest declarations, so it will run by default on every library/version, including ones where this feature is explicitly marked unsupported for sibling tests in the same class (for example manifests/python.yml:1800-1801, manifests/nodejs.yml:2130-2131, manifests/ruby.yml:1557-1558, manifests/cpp.yml:290-291). In this repo, manifest rules control activation/deactivation at collection time (conftest.py::pytest_collection_modifyitems), so missing entries here can cause broad CI regressions outside Java/.NET/Golang support windows.

Useful? React with 👍 / 👎.

"""When a parent span has a manually set service name
A child span that inherits the same service should also have _dd.svc_src set to "m"
"""
with (
test_library,
test_library.dd_start_span("parent", service="my-service") as parent,
test_library.dd_start_span("child", parent_id=parent.span_id),
):
pass

traces = test_agent.wait_for_num_traces(1, sort_by_start=False)
trace = find_trace(traces, parent.trace_id)

child_span = next(s for s in trace if s["name"] == "child")
assert child_span["meta"].get("_dd.svc_src") == "m", (
f"Expected _dd.svc_src='m' on child span, got: {child_span['meta'].get('_dd.svc_src')!r}"
)


@scenarios.parametric
@features.base_service
Expand Down
Loading