fix(fabric): restore ignores for legacy .paperclip state#96
Closed
DeployFaith wants to merge 1 commit into
Closed
Conversation
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
.paperclipignores with.fabric, leaving legacy Paperclip runtime state unignored and able to enter Docker build contexts or be accidentally committed..paperclip/.paperclip-localdirectories may contain config,.env, DB files, tokens, or keys and should be denied from both git and Docker contexts as a defensive measure.Description
.paperclipand.paperclip-localtoapps/fabric/.dockerignoreto exclude legacy Paperclip runtime state from Docker build contexts..paperclip/and.paperclip-local/toapps/fabric/.gitignoreto make accidental commits of legacy Paperclip state less likely.apps/fabric/.dockerignoreandapps/fabric/.gitignoreand preserves current.fabricignores and existing behavior.Testing
git -C apps/fabric check-ignore .fabric/config.json .paperclip/config.json .fabric-local/token .paperclip-local/tokenand verified legacy Paperclip paths are now ignored.git diff --checkwith no new ignore-related warnings.npm run typecheckinapps/fabricwhich completed successfully.npm run lintbut the workspace has nolintscript.npm testinapps/fabric; the test run surfaced unrelated existing failures (embedded Postgres root-user limitation and several failing unit tests) and was interrupted, so full test-suite success was not verified in this environment.Codex Task