feat(brake_release): launch brake_release_node alongside e_stop - #6
Open
Schwimo wants to merge 2 commits into
Open
feat(brake_release): launch brake_release_node alongside e_stop#6Schwimo wants to merge 2 commits into
Schwimo wants to merge 2 commits into
Conversation
Start the brake_release_node (from duatic_e_stop) in the bringups so the gamepad brake-release combo works. Mirrors the e_stop_node placement and conditions (incl. UnlessCondition(start_as_subcomponent) on DynaArm).
Contributor
|
@Schwimo is this needed and is it tested ? |
Contributor
Author
|
This is needed but not tested I think |
Contributor
Author
|
@mbloechli Please test this also. |
Contributor
I currently do not a have a single freestanding arm in the office I can test this with. |
Contributor
|
@Schwimo I think you can test this yourself in esslingen ? |
Contributor
Author
I can't test if the real brake gets triggered. But the base function I can test yes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start the brake_release_node (from duatic_e_stop) in the bringups so the gamepad brake-release combo works. Mirrors the e_stop_node placement and conditions (incl. UnlessCondition(start_as_subcomponent) on DynaArm).