Skip to content

Add MOAB driver changes for wave-ice coupling and fix array bounds issue.#8225

Merged
rljacob merged 2 commits into
E3SM-Project:masterfrom
sbrus89:ww3/moab-wave-ice-fix
Mar 31, 2026
Merged

Add MOAB driver changes for wave-ice coupling and fix array bounds issue.#8225
rljacob merged 2 commits into
E3SM-Project:masterfrom
sbrus89:ww3/moab-wave-ice-fix

Conversation

@sbrus89
Copy link
Copy Markdown
Contributor

@sbrus89 sbrus89 commented Mar 26, 2026 •
edited by rljacob
Loading

Add the MOAB driver changes for wave-ice coupling from e8b7da4

It also fixes an array bounds issue for debug gnu builds.

[BFB]

@sbrus89 sbrus89 requested review from erinethomas and rljacob March 26, 2026 18:16
@sbrus89 sbrus89 added BFB PR leaves answers BFB MOAB Involves the MOAB library Wave labels Mar 26, 2026
@vijaysm
Copy link
Copy Markdown
Contributor

vijaysm commented Mar 26, 2026

Thanks @sbrus89. To clarify, the MOAB driver doesn't support the WAV model yet. Are you just syncing changes from driver-mct?

@sbrus89
Copy link
Copy Markdown
Contributor Author

sbrus89 commented Mar 27, 2026 •
edited
Loading

Yes, exactly. Right now the changes from #7958 are causing a fail in the Vmoab test in the integration suite.

@sbrus89
Copy link
Copy Markdown
Contributor Author

sbrus89 commented Mar 27, 2026

In testing this I found a divide by zero issue caused by the array indexing change:

106: forrtl: error (73): floating divide by zero 
106: Image              PC                Routine            Line        Source     
106: libpnetcdf.so.3.0  000015554B27862C  for__signal_handl     Unknown  Unknown
106: libpthread-2.28.s  00001555473CF990  Unknown               Unknown  Unknown
106: e3sm.exe           0000000001D4DF3B  icepack_wavefracs         468  icepack_wavefracspec.f90
106: e3sm.exe           0000000001D48633  icepack_wavefracs         276  icepack_wavefracspec.f90
106: e3sm.exe           0000000000CFD8C7  seaice_icepack_mp        3557  mpas_seaice_icepack.f90
106: e3sm.exe           0000000000C84809  seaice_icepack_mp        1427  mpas_seaice_icepack.f90
106: e3sm.exe           0000000000A5681F  seaice_time_integ         173  mpas_seaice_time_integration.f90
106: e3sm.exe           00000000009BE3CE  ice_comp_mct_mp_i        1195  ice_comp_mct.f90
106: e3sm.exe           00000000004B1FBE  component_mod_mp_         784  component_mod.F90
106: e3sm.exe           0000000000468D6C  cime_comp_mod_mp_        3062  cime_comp_mod.F90
106: e3sm.exe           000000000049905D  MAIN__                    153  cime_driver.F90
106: e3sm.exe           000000000042FD02  Unknown               Unknown  Unknown
106: libc-2.28.so       0000155547021865  __libc_start_main     Unknown  Unknown
106: e3sm.exe           000000000042FC0E  Unknown               Unknown  Unknown

@rljacob rljacob self-assigned this Mar 29, 2026
@rljacob rljacob added the Coupler Related to code in driver-mct or driver-moab or component connections to the coupler. label Mar 29, 2026
@rljacob
Copy link
Copy Markdown
Member

rljacob commented Mar 30, 2026 •
edited
Loading

Not sure what you mean by "the array indexing change". Are you trying to run with the new coupling? I think all you need to get past the moab build error is the changes in driver-moab/cime_config.

@rljacob
Copy link
Copy Markdown
Member

rljacob commented Mar 30, 2026

Was the error you mentioned in #8225 (comment) already fixed?

rljacob added a commit that referenced this pull request Mar 30, 2026
@rljacob
Merge branch 'sbrus/ww3/moab-wave-ice-fix' into next (PR #8225)
c64f86b 
Add the MOAB driver changes for wave-ice coupling from e8b7da4

It also fixes an array bounds issue for debug gnu builds.

[BFB]
sbrus89
sbrus89 commented Mar 31, 2026
View reviewed changes
Comment thread components/mpas-seaice/src/shared/mpas_seaice_icepack.F
Comment on lines -596 to +597
waveFrequency = waveFrequency_TEMP(2:nFrequencies-1)
waveFreqBinWidth = waveFreqBinWidth_TEMP(2:nFrequencies-1)
waveFrequency(1:nFrequencies-2) = waveFrequency_TEMP(2:nFrequencies-1)
waveFreqBinWidth(1:nFrequencies-2) = waveFreqBinWidth_TEMP(2:nFrequencies-1)
Copy link
Copy Markdown
Contributor Author

@sbrus89 sbrus89 Mar 31, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rljacob, this was the indexing change that I was hoping would fix the wave test fail in the extra coverage suite: https://my.cdash.org/tests/368302943, but it ended up causing divide by zero errors when I ran the wave developer tests.

Copy link
Copy Markdown
Member

@rljacob rljacob Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. It wasn't clear if your #8225 (comment) was something you were noting for the record or something you wanted me to fix.

Copy link
Copy Markdown
Contributor Author

@sbrus89 sbrus89 Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that. I was going to look into fixing it.

@rljacob rljacob merged commit d7607ce into E3SM-Project:master Mar 31, 2026
6 checks passed
@sbrus89 sbrus89 mentioned this pull request Apr 29, 2026
Merged
@rljacob rljacob changed the title Add MOAB driver changes for wave-ice coupling Add MOAB driver changes for wave-ice coupling and fix array bounds issue. May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rljacob rljacob rljacob approved these changes

@erinethomas erinethomas Awaiting requested review from erinethomas

Assignees

@rljacob rljacob

Labels

BFB PR leaves answers BFB Coupler Related to code in driver-mct or driver-moab or component connections to the coupler. MOAB Involves the MOAB library Wave

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sbrus89 @vijaysm @rljacob