Neutralise third-party addon references in two code comments - #1263
Open
Kirihasio2 wants to merge 1 commit into
Open
Neutralise third-party addon references in two code comments#1263Kirihasio2 wants to merge 1 commit into
Kirihasio2 wants to merge 1 commit into
Conversation
Both comments explain a technique that stands on its own, and cited other addons only as corroboration. Reworded to describe the technique directly: - UpdateKeybinds: routing keybinds through the button so the keypress reads the paged "action" attr - Skin_Guild: hooksecurefunc post-hooks being taint-safe by design Comments only, no behaviour change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two code comments cited other addons as corroboration for a technique that already stands on its own. Reworded to describe the technique directly.
UpdateKeybinds— routing keybinds through the button so the keypress reads the pagedactionattrSkin_Guild—hooksecurefuncpost-hooks being taint-safe by designComments only. No behaviour change, verified by diffing: every changed line is a comment.
Deliberately left alone: the conflict-warning entries, addon-detection prefixes, and shared-media texture keys in
EllesmereUI.lua(plus their locale strings). Those name other addons functionally — to detect them or warn about them — and removing them would break features and six locale files.