Skip to content

Neutralise third-party addon references in two code comments #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kirihasio2 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Neutralise third-party addon references in two code comments #1263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions EllesmereUIActionBars/EllesmereUIActionBars.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11253,8 +11253,8 @@ local function UpdateKeybinds()
-- keybind would fire the un-paged slot while the icon (our explicit
-- "action" attr) repages. Route those bars' keybinds through the
-- button (SetOverrideBindingClick) so the keypress reads our paged
-- "action" attr -- exactly what empower/flyout already do, and what
-- ElvUI/Bartender do for every button via LibActionButton.
-- "action" attr -- exactly what empower/flyout already do, and the
-- standard approach for any bar whose slots are addon-managed.
--
-- Class-default form paging (Druid/Rogue) is NOT custom paging: it
-- rides on bonusbar, a native engine concept that ACTIONBUTTONn
Expand Down
2 changes: 1 addition & 1 deletion EllesmereUIBlizzardSkin/EllesmereUIBlizzardSkin_WindowPacks.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3276,7 +3276,7 @@ local function Skin_Guild()
-- secure roster refresh that a protected guild action (SetNote /
-- SetGuildRankOrder) triggers, tainting that action -> ADDON_ACTION_FORBIDDEN
-- (root-caused by bisection; @Halt57/@woaw guild-note reports). hooksecurefunc
-- post-hooks are taint-safe by design -- the pattern ElvUI uses here.
-- post-hooks are taint-safe by design, which is the standard fix here.
if ml and ml.RefreshListDisplay and not GetFFD(ml).colRefreshHooked then
GetFFD(ml).colRefreshHooked = true
hooksecurefunc(ml, "RefreshListDisplay", WSkin.Debounce(SkinRosterColumns))
Expand Down