Skip to content
This repository was archived by the owner on Jun 1, 2026. It is now read-only.

[WIP] disaggregate by-value OpTypeStruct/OpTypeArray inputs/outputs.#29

Closed
eddyb wants to merge 18 commits into
mainfrom
disaggregate
Closed

[WIP] disaggregate by-value OpTypeStruct/OpTypeArray inputs/outputs.#29
eddyb wants to merge 18 commits into
mainfrom
disaggregate

Conversation

@eddyb

@eddyb eddyb commented May 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

This should allow us to always reason about the leaves of "aggregates", without any superfluous nesting - especially relevant to logical pointers, which SPIR-V disallows wrapping in any other data types, and which qptr would prefer to always interact with directly.

TODO:

  • global initializers should have disaggregated leaves for initializers
    • potential compromise: use GlobalVarShape::TypedInterface when an initializer is present
  • longer PR description (add comparison!), and CHANGELOG entry (reuse details from Value docs additions?)

@eddyb eddyb mentioned this pull request Jun 7, 2023
Merged
@eddyb eddyb force-pushed the disaggregate branch 3 times, most recently from e572cb3 to 46e9123 Compare June 24, 2023 11:30
@eddyb eddyb mentioned this pull request Jun 26, 2023
Closed
@eddyb eddyb mentioned this pull request Jul 8, 2023
Open
@eddyb eddyb force-pushed the disaggregate branch 2 times, most recently from 124b0cf to becf30c Compare October 6, 2023 23:12
@eddyb eddyb force-pushed the disaggregate branch 3 times, most recently from 7b60637 to 11cd6f7 Compare October 27, 2023 16:51
@eddyb eddyb mentioned this pull request Oct 27, 2023
Merged
github-merge-queue Bot pushed a commit that referenced this pull request Oct 27, 2023
@eddyb
Combine TypeCtor/ConstCtor and "ctor args" into a single `TypeKin…
bccdf3f 
…d`/`ConstKind`. (#51)

The "constructor" idea was cute, but a mistake. At the end of the day
(see #1, #50, #29), the direction to move into is simpler and/or flatter
types and constants, *not* favoring the hierarchical ones.
@eddyb eddyb force-pushed the disaggregate branch 4 times, most recently from 07ca42b to f4464b3 Compare November 5, 2023 00:22
@eddyb eddyb force-pushed the disaggregate branch 3 times, most recently from 2f1acf8 to 9939ddb Compare November 8, 2023 05:38
@eddyb eddyb force-pushed the disaggregate branch 2 times, most recently from a0a887f to 7615c90 Compare January 31, 2024 14:19
eddyb added 18 commits January 31, 2024 17:01
@eddyb
Add ConstKind::Undef (i.e. SPIR-V OpUndef).
5511dcd
@eddyb
Add TypeKind::Scalar&ConstKind::Scalar for bool/int/float types&c…
0a64880 
…onsts.
@eddyb
Add DataInstKind::Scalar for pure scalars->scalars ops.
f31e5a2
@eddyb
Add SelectionKind::Switch, using one scalar::Const for each case'…
ad22784 
…s constant.
@eddyb
WIP: OpSpecConstantOp
f61e300
@eddyb
Add TypeKind::Vector&ConstKind::Scalar for vector types&consts.
44faddc
@eddyb
Add DataInstKind::Vector for pure vector ops.
b349dea
@eddyb
qptr/analyze: fix some latent issues in merging, caused by ZSTs.
74fde56
@eddyb
qptr/analyze: don't panic on oddball Const pointers.
d4b0eb0
@eddyb
qptr: add an immediate offset to Load/Store ops.
44cf1cd
@eddyb
qptr/lower: more aggressively strip Offset(0) and remove unused ins…
145051e 
…tructions.
@eddyb
spv/lift: abandon Result for allocating IDs and do it far more eage…
53c6cec 
…rly.
@eddyb
spv/lower: don't assign IDs ahead of time.
22c8b95
@eddyb
spv: disaggregate by-value OpTypeStruct/OpTypeArray inputs/outputs.
d710313
@eddyb
qptr/lower: expand aggregate Op{Load,Store} into leaf loads/stores.
fcc57bd
@eddyb
qptr/lower: expand OpCopyMemory into leaf loads+stores (in the abse…
d4a9443 
…nce of large arrays).
@eddyb
print: attempt to improve GlobalVar printing by using named arguments.
830b4e8
@eddyb
[WIP] GV init disaggregate
c61d096
@rust-gpu-bot rust-gpu-bot mentioned this pull request Nov 13, 2024
Closed
This was referenced Apr 27, 2026
Draft
Draft
@eddyb

eddyb commented Apr 27, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by:

@eddyb eddyb closed this Apr 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@eddyb