rpc_client: fix ACK counter start value - #120
Merged
Merged
Conversation
Start the ACK counter at 0, not negative. This prevents the possibility of too many buffers pending on the receiving device, which would cause buffers to drop and hence the upload to fail. This slightly reduces write throughput. Signed-off-by: Jordan Yates <jordan@embeint.com>
Move the hardcoded ack period to a class variable that can be updated, and support an ack period of 0 without blasting the entire file as quickly as possible. Signed-off-by: Jordan Yates <jordan@embeint.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start the ACK counter at 0, not negative. This prevents the possibility of too many buffers pending on the receiving device, which would cause buffers to drop and hence the upload to fail. This slightly reduces write throughput.