Skip to content

rpc_client: fix ACK counter start value #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JordanYates merged 2 commits into from
Feb 24, 2026
Merged

rpc_client: fix ACK counter start value #120

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36c2084
rpc_client: fix ACK counter start value
JordanYates Feb 24, 2026
5925744
rpc_client: reduce harcoding
JordanYates Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions src/infuse_iot/rpc_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ def __init__(
self._id = infuse_id
self._max_payload = max_payload
self._rx_cb = rx_cb
self.ack_period = 2
self.no_ack_sleep = 0.01

def set_timeout(self, timeout: float):
self._timeout = timeout
Expand Down Expand Up @@ -105,9 +107,8 @@ def _run_data_send_core(
rsp_decoder: Callable[[bytes], ctypes.LittleEndianStructure],
) -> tuple[rpc.ResponseHeader | None, ctypes.LittleEndianStructure | None]:
self._request_id += 1
ack_period = 2
header = rpc.RequestHeader(self._request_id, cmd_id) # type: ignore
data_hdr = rpc.RequestDataHeader(total_size, ack_period)
data_hdr = rpc.RequestDataHeader(total_size, self.ack_period)

request_packet = bytes(header) + bytes(data_hdr) + params
pkt = PacketOutput(
Expand All @@ -127,7 +128,7 @@ def _run_data_send_core(
return self._finalise_command(recv, rsp_decoder)

# Send data payloads chunked as requested
ack_cnt = -ack_period
ack_cnt = 0
offset = 0
for chunk_id, chunk in enumerate(data):
hdr = rpc.DataHeader(self._request_id, chunk_id if packet_idx else offset)
Expand All @@ -139,16 +140,20 @@ def _run_data_send_core(
pkt_bytes,
)
self._client.send(GatewayRequestEpacketSend(pkt))
ack_cnt += 1

# Wait for ACKs at the period
if ack_cnt == ack_period:
recv = self._wait_data_ack()
if recv is None:
return None, None
if recv.ptype == InfuseType.RPC_RSP:
return self._finalise_command(recv, rsp_decoder)
ack_cnt = 0
if self.ack_period:
ack_cnt += 1
# Wait for ACKs at the period
if ack_cnt == self.ack_period:
recv = self._wait_data_ack()
if recv is None:
return None, None
if recv.ptype == InfuseType.RPC_RSP:
return self._finalise_command(recv, rsp_decoder)
ack_cnt = 0
else:
# Limit throughput to avoid blasting the entire file
time.sleep(self.no_ack_sleep)

offset += len(chunk)
if progress_cb:
Expand Down