Skip to content

feat: package build#8

Merged
rikled merged 4 commits into
mainfrom
feat/pkgbuild
May 26, 2026
Merged

feat: package build#8
rikled merged 4 commits into
mainfrom
feat/pkgbuild

Conversation

@rikled

@rikled rikled commented May 11, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
rikled added 2 commits May 11, 2026 17:37
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
@rikled rikled requested a review from juliusknorr May 12, 2026 21:23
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>

@chrip chrip left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Makefile path rebranding — all onlyoffice paths are changed to euro-office across NGINX_LOG, NGINX_CASH, DS_ROOT, DS_FILES, DS_EXAMPLE. Looks correct for the rebrand.

  2. Admin panel logic commented out — the ifeq block for documentserver-de/documentserver-ee products is now commented out in both the welcome page build and the M4_DS_ADMINPANEL_ENABLE m4 param. Is this intentional? If the admin panel is being removed entirely, consider adding a comment explaining why. If it's temporary, consider using a build flag instead of inline comments.

  3. favicon_eo.svg — new SVG favicon added. Good touch for branding. Note: the file is missing a trailing newline (\ No newline at end of file). Consider adding one for consistency with other SVG files.

  4. Welcome page HTML files — favicon references and JWT command paths updated consistently across docker.html, linux.html, linux-rpm.html, k8s.html, win.html, example-disabled.html. Looks thorough.

@rikled

rikled commented May 26, 2026

Copy link
Copy Markdown
Member Author
2. **Admin panel logic commented out** — the `ifeq` block for `documentserver-de`/`documentserver-ee` products is now commented out in both the welcome page build and the `M4_DS_ADMINPANEL_ENABLE` m4 param. Is this intentional? If the admin panel is being removed entirely, consider adding a comment explaining why. If it's temporary, consider using a build flag instead of inline comments.

Its commented out because this was the guard for developer and enterprise edition, so commenting this out actually activates the admin interface

@rikled rikled merged commit 9024a90 into main May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants