feat: package build#8
Conversation
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
chrip
left a comment
There was a problem hiding this comment.
-
Makefile path rebranding — all
onlyofficepaths are changed toeuro-officeacross NGINX_LOG, NGINX_CASH, DS_ROOT, DS_FILES, DS_EXAMPLE. Looks correct for the rebrand. -
Admin panel logic commented out — the
ifeqblock fordocumentserver-de/documentserver-eeproducts is now commented out in both the welcome page build and theM4_DS_ADMINPANEL_ENABLEm4 param. Is this intentional? If the admin panel is being removed entirely, consider adding a comment explaining why. If it's temporary, consider using a build flag instead of inline comments. -
favicon_eo.svg — new SVG favicon added. Good touch for branding. Note: the file is missing a trailing newline (
\ No newline at end of file). Consider adding one for consistency with other SVG files. -
Welcome page HTML files — favicon references and JWT command paths updated consistently across docker.html, linux.html, linux-rpm.html, k8s.html, win.html, example-disabled.html. Looks thorough.
Its commented out because this was the guard for developer and enterprise edition, so commenting this out actually activates the admin interface |
see: Euro-Office/DocumentServer#92