Drop support netstandard1.4, replace with net10.0#153
Closed
Drop support netstandard1.4, replace with net10.0#153
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the target framework support by dropping the legacy .NET Standard 1.4 framework and replacing it with .NET 8.0, while maintaining support for .NET Standard 2.0 and .NET Framework 4.6.2.
- Replaced netstandard1.4 target framework with net8.0 in the project file
- Updated conditional compilation directives to use NET8_0 instead of NETSTANDARD1_4
- Removed netstandard1.4-specific package dependencies that are no longer needed
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| SignhostAPIClient.csproj | Updated target frameworks and conditional defines, removed legacy package references |
| StreamContentDigestOptionsExtensions.cs | Updated preprocessor directives to target NET8_0 instead of NETSTANDARD1_4 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ATimmeh33
force-pushed
the
fix/drop-support-netstandard1.4
branch
from
c142dcc to
efd01b0
Compare
ATimmeh33
changed the title
Modernizes the codebase by upgrading to .NET 10, enabling use of newer language features and APIs. Removes legacy netstandard1.4 support and related conditional logic to simplify maintenance. Improves compatibility with future .NET releases.
- Replaced Newtonsoft.Json with System.Text.Json for JSON serialization and deserialization across the API client. - Updated interfaces and classes to reflect consistent naming conventions (e.g., ISignHostApiClient to ISignhostApiClient). - Removed obsolete JsonConverter classes that were specific to Newtonsoft.Json. - Introduced centralized JSON serializer options in SignhostJsonSerializerOptions for consistent serialization behavior. - Added new JSON test resources for various transaction scenarios to ensure compatibility with the updated serialization logic.
ATimmeh33
force-pushed
the
fix/drop-support-netstandard1.4
branch
from
efd01b0 to
f22fc4b
Compare
This was referenced Nov 21, 2025
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request modernizes and simplifies the test infrastructure for handling API responses in the
SignhostAPIClient.Testsproject. The main changes include migrating test JSON data from embedded resources in.resxfiles to standalone.jsonfiles, introducing a utility class for loading these JSON files, and cleaning up obsolete code. Additionally, there are minor updates to documentation and build configuration.Test infrastructure modernization:
APIResponses.Designer.csfile, which previously provided access to embedded resource strings for test responses, in favor of a more maintainable approach using standalone.jsonfiles..jsonfiles (AddTransaction.json,DeleteTransaction.json,GetTransaction.json,MinimalTransactionResponse.json,MockPostbackInvalid.json,AddOrReplaceFileMetaToTransaction.json) to thesrc/SignhostAPIClient.Tests/JSON/directory to store test API responses as plain JSON. [1] [2] [3] [4] [5]JsonResources.csclass, which provides strongly-typed accessors for loading JSON test data from the new files, improving code readability and maintainability.Build and documentation updates:
.NET 10.xinstead of.NET 8.x, ensuring compatibility with future .NET releases.README.mdexample code to match the actual codebase (SignhostApiClientSettingsandSignhostApiClient).Minor cleanup:
.ncrunchprojectand.ncrunchsolutionentries from.gitattributesto reduce clutter.