Skip to content

fix(neoforge): coordinate recipe load producers - #12

Open
Exohayvan wants to merge 2 commits into
minecraft/neoforge-1.21.xfrom
minecraft-neoforge-1.21.x-fix-recipe_snapshot_concurrency
Open

fix(neoforge): coordinate recipe load producers#12
Exohayvan wants to merge 2 commits into
minecraft/neoforge-1.21.xfrom
minecraft-neoforge-1.21.x-fix-recipe_snapshot_concurrency

Conversation

@Exohayvan

@Exohayvan Exohayvan commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • Serializes delayed mixin recipe loads and snapshots their input.
  • Coordinates the mixin path with NeoForge server-start recipe loading before either resets global EMC state.
  • Adds an exclusive-load regression test.

Fixes #4

Validation

  • ./gradlew test --tests net.exohayvan.dissolver_enhanced.data.RecipeLoadCoordinatorTest

@Exohayvan Exohayvan linked an issue Jul 19, 2026 that may be closed by this pull request
[Bug]: Fabric recipe snapshot can throw ConcurrentModificationException #4
Open
@Exohayvan Exohayvan added the type:bug A defect or incorrect behavior label Jul 20, 2026
Repository owner deleted a comment from sonarqubecloud Bot Jul 20, 2026
@Exohayvan Exohayvan added P1 Critical: makes the mod unusable or fully breaks core functionality area:emc EMC values, calculation, storage, or overrides area:recipes Recipe loading, querying, snapshots, or derived EMC loader:neoforge NeoForge-specific status:in-review A linked pull request is awaiting review or checks labels Jul 20, 2026
This was referenced Jul 20, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area:emc EMC values, calculation, storage, or overrides area:recipes Recipe loading, querying, snapshots, or derived EMC loader:neoforge NeoForge-specific P1 Critical: makes the mod unusable or fully breaks core functionality status:in-review A linked pull request is awaiting review or checks type:bug A defect or incorrect behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Fabric recipe snapshot can throw ConcurrentModificationException

1 participant

@Exohayvan