Skip to content

Remove dependencies argument from useOnyx - #800

Merged
Julesssss merged 2 commits into
Expensify:mainfrom
callstack-internal:feature/onyx-store-pr-3
Aug 3, 2026
Merged

Remove dependencies argument from useOnyx#800
Julesssss merged 2 commits into
Expensify:mainfrom
callstack-internal:feature/onyx-store-pr-3

Conversation

@fabioh8010

@fabioh8010 fabioh8010 commented Jun 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Details

This PR removes the dependencies arg completely from Onyx. Plan is explained here.

Related Issues

Expensify/App#95582
Expensify/App#94595

Linked E/App PR

Expensify/App#97594

Automated Tests

Unit tests were added/removed accordingly.

Manual Tests

  1. Login with an account with Workspace.
  2. Create a new expense report, add an expense without Category.
  3. Wait a bit, assert the expense is flagged as missing Category.
  4. Submit the report, approve it, assert the process works.
  5. Fill the missing Category, assert the violation is gone.
  6. Mark the report as paid, assert the process works.

Author Checklist

  • I linked the correct issue in the ### Related Issues section above
  • I linked the corresponding Expensify/App PR in the ### Linked E/App PR section above, and verified this change against it (E/App CI passed and manual testing completed)
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-07-31.at.13.26.37.mov

@fabioh8010 @claude
Remove useOnyx's dependencies argument; extract createMemoizedSelector
5739db8 
Drop the 3rd positional `dependencies` argument from useOnyx (consumers
express external dependencies via a useMemo'd selector instead). Extract the
selector memoizer into lib/createMemoizedSelector.ts — caches by input
reference with a deepEqual fallback so the returned reference stays stable —
and wire it into useOnyx. Delete the now-unused useLiveRef.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@Julesssss
Julesssss self-requested a review June 24, 2026 22:05
@mountiny mountiny mentioned this pull request Jun 25, 2026
Open
@Julesssss

Julesssss commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Hey @fabioh8010 I'm happy to review when ready. Is this the correct linked App PR?

@fabioh8010

fabioh8010 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Yes, but we agreed in changing the plan a little bit:

  1. Prepare some batch PRs to remove the dependencies from useOnyx in E/App first
  2. If necessary, a new lint rule to prevent to new usages of dependencies
  3. Straight Onyx PR + E/App to remove the argument + any other new hook using it

@mountiny mountiny mentioned this pull request Jul 8, 2026
Open
3 tasks
@fabioh8010

fabioh8010 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 31, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 05cb035cec

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread lib/useOnyx.ts
@fabioh8010 fabioh8010 changed the title [WIP] Remove dependencies argument from useOnyx Remove dependencies argument from useOnyx Jul 31, 2026
@fabioh8010
fabioh8010 marked this pull request as ready for review July 31, 2026 20:45
@fabioh8010
fabioh8010 requested a review from a team as a code owner July 31, 2026 20:45
@melvin-bot
melvin-bot Bot removed the request for review from a team July 31, 2026 20:45
@fabioh8010 fabioh8010 mentioned this pull request Jul 31, 2026
Open
@mountiny
mountiny requested a review from hoangzinh August 3, 2026 08:29
hoangzinh
hoangzinh approved these changes Aug 3, 2026
View reviewed changes

@hoangzinh hoangzinh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Android
Screen.Recording.2026-08-03.at.18.43.22.mov
Web
Screen.Recording.2026-08-03.at.18.40.14.mov

@Julesssss
Julesssss merged commit da9b59f into Expensify:main Aug 3, 2026
16 checks passed
@os-botify

os-botify Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

🚀 Published to npm in 3.0.95 🎉

@fabioh8010 fabioh8010 mentioned this pull request Aug 7, 2026
Open
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@Julesssss Julesssss Julesssss approved these changes
@mountiny mountiny mountiny approved these changes
+1 more reviewer
@hoangzinh hoangzinh hoangzinh approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@fabioh8010 fabioh8010

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fabioh8010 @Julesssss @hoangzinh @mountiny