Conversation
Mobby42
requested review from
MikeKantrowitz,
armadilloz and
batchen1
as code owners
batchen1
requested changes
Feb 20, 2026
| @@ -0,0 +1,1203 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
Somebody pushed the layout a few days ago, just want to make sure this includes these changes. Also - seems like there's a lot of debug stuff here. We may want to clean it up.
|
|
||
|
|
||
| //Diags | ||
| public static final double HOPPER_DIAGS_ENCODER = 1; |
Contributor
There was a problem hiding this comment.
should we add encoder diag for turret, angler, intakeDeployer?
|
|
||
| Robot.getDiagnostics() | ||
| .addDiagnosable( | ||
| new DiagSparkMaxEncoder( |
Contributor
There was a problem hiding this comment.
add limit switches to climber. Top and Bottom.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.