fix(api): missing trailing / route for environment-document - #15
Open
Totodore wants to merge 1 commit into
Open
Conversation
emyller
requested changes
Aug 13, 2026
emyller
left a comment
emyller
left a comment
There was a problem hiding this comment.
Sorry for taking my previous approval back. Would you think it makes sense to ensure the intended behaviour in tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each route was duplicated manually to work with trailing slash. However the
/environment-documentpath was not. And the Rust SDK use/environment-document/leading to 404.Fix this by using the
NormalizePathLayerrather than duplicating the routes which is error prone.Side notes
Error message in the rust SDK are particularly not helpful:
Failed to update environment: Flagsmith API error: . Will retry on next interval.. I will open a PR later to fix this.Don't hesitate if this need any change.