Skip to content

fix(api): missing trailing / route for environment-document #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Totodore wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(api): missing trailing / route for environment-document #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ license = "BSD-3-Clause"
axum = { version = "0.8", features = ["macros"] }
tokio = { version = "1", features = ["full"] }
tower = "0.5"
tower-http = { version = "0.6", features = ["compression-gzip", "cors", "trace"] }
tower-http = { version = "0.6", features = ["compression-gzip", "cors", "trace", "normalize-path"] }
reqwest = { version = "0.13", features = ["json", "gzip"] }
serde = { version = "1", features = ["derive"] }
serde_json = "1"
Expand Down
9 changes: 5 additions & 4 deletions src/routes/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ use axum::{
routing::{get, post},
};
use std::sync::Arc;
use tower_http::{compression::CompressionLayer, cors::CorsLayer, trace::TraceLayer};
use tower_http::{
compression::CompressionLayer, cors::CorsLayer, normalize_path::NormalizePathLayer,
trace::TraceLayer,
};

pub fn create_router(settings: AppSettings) -> (Router, Arc<EnvironmentService>) {
let environment_service = Arc::new(EnvironmentService::new(settings));
Expand All @@ -24,18 +27,16 @@ pub fn create_router(settings: AppSettings) -> (Router, Arc<EnvironmentService>)
.route("/proxy/health/liveness", get(health::liveness_check))
// Flags routes (with and without trailing slash)
.route("/api/v1/flags", get(flags::get_flags))
.route("/api/v1/flags/", get(flags::get_flags))
// Identities routes (with and without trailing slash)
.route("/api/v1/identities", get(identities::get_identities))
.route("/api/v1/identities/", get(identities::get_identities))
.route("/api/v1/identities", post(identities::post_identities))
.route("/api/v1/identities/", post(identities::post_identities))
// Environment document route
.route(
"/api/v1/environment-document",
get(environment_document::get_environment_document),
)
// Middleware layers
.layer(NormalizePathLayer::trim_trailing_slash())
.layer(CompressionLayer::new())
.layer(CorsLayer::permissive())
.layer(TraceLayer::new_for_http())
Expand Down
Loading