refactor(journey): migrate journey flow from legacy sdk to journey-client#468
Merged
Conversation
🦋 Changeset detectedLatest commit: af99389 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
vatsalparikh
changed the title
vatsalparikh
force-pushed
the
sdks-4796-journey-client
branch
6 times, most recently
from
a8e055f to
05fc510
Compare
vatsalparikh
requested review from
SteinGabriel,
ancheetah,
cerebrl and
ryanbas21
vatsalparikh
force-pushed
the
sdks-4796-journey-client
branch
3 times, most recently
from
64b7e73 to
e667e9d
Compare
vatsalparikh
force-pushed
the
sdks-4796-journey-client
branch
from
e667e9d to
e932be9
Compare
cerebrl
requested changes
Apr 27, 2026
Contributor
cerebrl
left a comment
cerebrl
left a comment
There was a problem hiding this comment.
I have one important comment and two minor comments. The redirect patter in the generic.svelte is what I'd like to focus on.
ryanbas21
reviewed
Apr 28, 2026
ryanbas21
reviewed
Apr 28, 2026
vatsalparikh
force-pushed
the
sdks-4796-journey-client
branch
from
f6ecf7f to
2369e30
Compare
cerebrl
reviewed
Apr 29, 2026
Contributor
cerebrl
left a comment
cerebrl
left a comment
There was a problem hiding this comment.
Still reviewing, but I did catch some imports that are still legacy. Is this a mistake, or do we not have a replacement for it in the new SDK?
cerebrl
requested changes
Apr 30, 2026
vatsalparikh
force-pushed
the
sdks-4796-journey-client
branch
from
a96af7e to
0077390
Compare
vatsalparikh
force-pushed
the
sdks-4796-journey-client
branch
from
7a62269 to
080bfd4
Compare
… and adding journey client redirect support
…or all callbacks to use journey client
…t; update READMEs for login-widget and repo
…can handle generic error case as completely generic, login failure is handled by its own branch
… ci pipeline warnings
… of creating new similar types
vatsalparikh
force-pushed
the
sdks-4796-journey-client
branch
from
080bfd4 to
1226501
Compare
SteinGabriel
reviewed
May 4, 2026
SteinGabriel
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
https://pingidentity.atlassian.net/browse/SDKS-4796
Reference:
https://github.com/ForgeRock/ping-javascript-sdk/blob/main/interface_mapping.md
Major files touched
https://github.com/ForgeRock/forgerock-web-login-framework/blob/sdks-4796-journey-client/core/journey-client.config.ts
https://github.com/ForgeRock/forgerock-web-login-framework/blob/sdks-4796-journey-client/core/journey/journey.store.ts
https://github.com/ForgeRock/forgerock-web-login-framework/blob/sdks-4796-journey-client/core/journey/journey.interfaces.ts
https://github.com/ForgeRock/forgerock-web-login-framework/blob/sdks-4796-journey-client/core/journey/_utilities/step.mock.ts
https://github.com/ForgeRock/forgerock-web-login-framework/blob/sdks-4796-journey-client/apps/login-app/src/routes/(app)/%2Blayout.ts
https://github.com/ForgeRock/forgerock-web-login-framework/blob/sdks-4796-journey-client/packages/login-widget/src/lib/_utilities/api.utilities.ts
https://github.com/ForgeRock/forgerock-web-login-framework/blob/sdks-4796-journey-client/packages/login-widget/src/lib/interfaces.ts
Failing login test
One Login test is failing because journey client currently does not create a step for LoginFailure. While JourneyLoginFailure step is defined, that logic is never executed or triggered because on non-2xx errors, journey client simply returns a GenericError without ever checking whether the login failure has happened. I am temporarily passing this test by handling login failure in generic error branch.
Created PR in Ping SDK repo to address this issue: ForgeRock/ping-javascript-sdk#574. To make sure all tests in this PR pass, the PR created in Ping SDK must be merged.
Testing done to ensure migration works
How to test
Ensure that you have configured FR_AM_WELLKNOWN_URL=https://openam-sdks.forgeblocks.com/am/oauth2/alpha/.well-known/openid-configuration