fix(import-order): fix import order for all files by defining an esli…

[vatsalparikh]

This PR fixes the import orders for all files in login framework.

Justin provided feedback on import order in the journey client migration PR: #468 (comment)

Based on his comment on another PR about the expected import order: https://github.com/ForgeRock/ping-javascript-sdk/pull/541/changes#r2956779035 I am creating this new PR which specifies the exact import order using an eslint rule.

Here is the import order rule:

// import any proper modules first
import { StepType } from '@forgerock/sdk-types';

// import any file-based modules second
import { journey } from './client.store.js';

// import any types from proper modules third
import type { GenericError } from '@forgerock/sdk-types';

// import any types from file-based modules last
import type { SomeType } from './some-file.js';

[changeset-bot]

⚠️ No Changeset found

Latest commit: 2629b2b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[ryanbas21]

I believe all the changes here are eslint/automatic so i just reviewed the eslint config changes.

if i'm right as long as CI is happy 👍

[vatsalparikh]

I believe all the changes here are eslint/automatic so i just reviewed the eslint config changes.

if i'm right as long as CI is happy 👍

Yes, I verified each file change yesterday, and it strictly follows all the rules to the T. We just need to review the import order in eslint, and see if it's not too strict. Either way, we can update it later if needed!