fix: report Submitted status for async run_tests#159
Merged
Conversation
…view helpers run_tests now returns Submitted instead of a misleading Success before Unity finishes the test run; run_tests_wait returns rejected submissions immediately instead of polling until timeout. Also consolidates duplicate HttpClient setup, cache load/save, and JSON-extraction helpers from the two Ollama quality-gate reviewers into a shared OllamaReviewSupport class. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_testsnow returnsSubmitted(not a misleadingSuccess) after Unity accepts the async request, before execution has started or finishedrun_tests_waitreturns rejected submissions immediately instead of polling until timeout, and still accepts legacySuccesstriggersOllamaReviewSupportclassCloses #99
Test plan
Editor/tests/test_routing.py— added/updated tests forSubmittedvsSuccesstrigger handling and immediate-return-on-rejection behavior; full suite passes via push validation