[BUGFIX] Ensure the right encoding - #429
Merged
simonschaufi merged 2 commits intoJul 14, 2026
Merged
Conversation
- Default to UTF-8 when the document has no encoding, so characters like umlauts stay literal instead of being written as numeric entities
- Convert XliffEncodingTest to the shared doTestFile/yieldFilesFromDirectory approach - Migrate encoding fixtures to the input/expected split .xlf.fixture format - Assert exact serialized output so non-ASCII characters stay literal without numeric entities - Drop the bespoke runner wiring and manual temp-file handling in favor of AbstractFractorTestCase
simonschaufi
approved these changes
Jul 14, 2026
Collaborator
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #428 by ensuring that the encoding is set to UTF-8 if not yet set properly in the respective xliff files. In general there may be 2 ways of not having the right encoding set:
<?xml ... ?>at all<?xml encoding=""?>or<?xml version="1.0"?>