Skip to content

[BUGFIX] Ensure the right encoding #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonschaufi merged 2 commits into from
Jul 14, 2026
Merged

[BUGFIX] Ensure the right encoding #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f01e33
[BUGFIX] Keep non-ASCII characters literal in XLIFF output
chrissonntag Jul 13, 2026
32b5795
[TASK] Align XLIFF encoding test with standard fixture pattern
chrissonntag Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/fractor-xliff/src/XliffFileProcessor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,10 @@ public function getAllRules(): iterable

private function saveXml(\DOMDocument $document): string
{
// Ensure a proper encoding so non-ASCII characters stay literal
if ($document->encoding === null || $document->encoding === '') {
$document->encoding = 'UTF-8';
}
$xml = $document->saveXML();
if ($xml === false) {
throw new ShouldNotHappenException('Could not save XLIFF document');
Expand Down
21 changes: 21 additions & 0 deletions packages/fractor-xliff/tests/XliffEncoding/Fixtures/french-accents.xlf.fixture
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" version="1.2">
<file source-language="fr" datatype="plaintext" original="messages">
<body>
<trans-unit id="key1" xml:space="preserve">
<source>Résultats à côté, déjà vu</source>
</trans-unit>
</body>
</file>
</xliff>
-----
<?xml version="1.0" encoding="UTF-8"?>
<xliff
xmlns="urn:oasis:names:tc:xliff:document:1.2" version="1.2">
<file source-language="fr" datatype="plaintext" original="messages">
<body>
<trans-unit id="key1" xml:space="preserve">
<source>Résultats à côté, déjà vu</source>
</trans-unit>
</body>
</file>
</xliff>
21 changes: 21 additions & 0 deletions packages/fractor-xliff/tests/XliffEncoding/Fixtures/symbols.xlf.fixture
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" version="1.2">
<file source-language="en" datatype="plaintext" original="messages">
<body>
<trans-unit id="key1" xml:space="preserve">
<source>Preis: 5€ – naïve façade</source>
</trans-unit>
</body>
</file>
</xliff>
-----
<?xml version="1.0" encoding="UTF-8"?>
<xliff
xmlns="urn:oasis:names:tc:xliff:document:1.2" version="1.2">
<file source-language="en" datatype="plaintext" original="messages">
<body>
<trans-unit id="key1" xml:space="preserve">
<source>Preis: 5€ – naïve façade</source>
</trans-unit>
</body>
</file>
</xliff>
28 changes: 28 additions & 0 deletions packages/fractor-xliff/tests/XliffEncoding/Fixtures/umlaut-and-rule-change.xlf.fixture
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
<?xml version="1.0" encoding="UTF-8"?>
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" version="1.2">
<file source-language="en" datatype="plaintext" original="messages">
<body>
<trans-unit id="greeting">
<source>Hello</source>
</trans-unit>
<trans-unit id="result" xml:space="preserve">
<source>Ergebnisse für "%s".</source>
</trans-unit>
</body>
</file>
</xliff>
-----
<?xml version="1.0" encoding="UTF-8"?>
<xliff
xmlns="urn:oasis:names:tc:xliff:document:1.2" version="1.2">
<file source-language="en" datatype="plaintext" original="messages">
<body>
<trans-unit id="greeting">
<source>Hello World</source>
</trans-unit>
<trans-unit id="result" xml:space="preserve">
<source>Ergebnisse für "%s".</source>
</trans-unit>
</body>
</file>
</xliff>
21 changes: 21 additions & 0 deletions packages/fractor-xliff/tests/XliffEncoding/Fixtures/umlauts-no-declaration.xlf.fixture
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" version="1.2">
<file source-language="en" datatype="plaintext" original="messages">
<body>
<trans-unit id="key1" xml:space="preserve">
<source>Ergebnisse für "%s". Ä Ö Ü ä ö ü ß</source>
</trans-unit>
</body>
</file>
</xliff>
-----
<?xml version="1.0" encoding="UTF-8"?>
<xliff
xmlns="urn:oasis:names:tc:xliff:document:1.2" version="1.2">
<file source-language="en" datatype="plaintext" original="messages">
<body>
<trans-unit id="key1" xml:space="preserve">
<source>Ergebnisse für "%s". Ä Ö Ü ä ö ü ß</source>
</trans-unit>
</body>
</file>
</xliff>
22 changes: 22 additions & 0 deletions packages/fractor-xliff/tests/XliffEncoding/Fixtures/umlauts-with-declaration.xlf.fixture
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<?xml version="1.0" encoding="UTF-8"?>
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" version="1.2">
<file source-language="en" datatype="plaintext" original="messages">
<body>
<trans-unit id="key1" xml:space="preserve">
<source>Ergebnisse für "%s". Ä Ö Ü ä ö ü ß</source>
</trans-unit>
</body>
</file>
</xliff>
-----
<?xml version="1.0" encoding="UTF-8"?>
<xliff
xmlns="urn:oasis:names:tc:xliff:document:1.2" version="1.2">
<file source-language="en" datatype="plaintext" original="messages">
<body>
<trans-unit id="key1" xml:space="preserve">
<source>Ergebnisse für "%s". Ä Ö Ü ä ö ü ß</source>
</trans-unit>
</body>
</file>
</xliff>
30 changes: 30 additions & 0 deletions packages/fractor-xliff/tests/XliffEncoding/XliffEncodingTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
<?php

declare(strict_types=1);

namespace a9f\FractorXliff\Tests\XliffEncoding;

use a9f\Fractor\Testing\PHPUnit\AbstractFractorTestCase;
use PHPUnit\Framework\Attributes\DataProvider;

/**
* Non-ASCII characters must stay literal and never be written as numeric entities.
*/
final class XliffEncodingTest extends AbstractFractorTestCase
{
#[DataProvider('provideData')]
public function test(string $filePath): void
{
$this->doTestFile($filePath);
}

public static function provideData(): \Iterator
{
return self::yieldFilesFromDirectory(__DIR__ . '/Fixtures', '*.xlf.fixture');
}

public function provideConfigFilePath(): string
{
return __DIR__ . '/config/fractor.php';
}
}
15 changes: 15 additions & 0 deletions packages/fractor-xliff/tests/XliffEncoding/config/fractor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<?php

declare(strict_types=1);

use a9f\Fractor\Configuration\FractorConfiguration;
use a9f\Fractor\ValueObject\Indent;
use a9f\FractorXliff\Configuration\XliffProcessorOption;
use a9f\FractorXliff\Tests\Fixtures\DummyXliffFractorRule;

return FractorConfiguration::configure()
->withOptions([
XliffProcessorOption::INDENT_CHARACTER => Indent::STYLE_TAB,
XliffProcessorOption::INDENT_SIZE => 1,
])
->withRules([DummyXliffFractorRule::class]);