test: close the de-graphene coverage gap#99
Merged
Conversation
The cleanup churned a lot of source (new graphene-free compute + ported resolvers), leaving codecov patch/project red on PR #97. Cover the new lines directly: - tests/test_compute.py — color_scale/compute.py: get_normaliser (log/lin/error), log_intervals (narrow/wide/same-decade/slim+ensure_max), compute_colour_scale (log/lin/ unknown-normalisation error), get_colour_values (incl. the None->"x000000" sentinel). - tests/test_schema_helpers.py — _style_dict(None), _fso_dict(falsy), and the null-sortby-item skip in filter_ruptures. compute.py/schema.py/ruptures.py/geojson_style_util.py now 100%. One genuinely unreachable legacy branch in log_intervals.slim (caller passes the min as 'max', so largest < it never holds) is marked '# pragma: no cover' with a note. 96 pass / 10 skipped; ruff + mypy clean.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## deploy-test #99 +/- ##
===============================================
+ Coverage 93.82% 95.08% +1.26%
===============================================
Files 12 12
Lines 1101 1099 -2
Branches 64 63 -1
===============================================
+ Hits 1033 1045 +12
+ Misses 48 41 -7
+ Partials 20 13 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #98. The de-graphene cleanup churned a lot of source, leaving codecov patch/project red on the promote PR #97. This covers the new lines directly so #97 goes green.
tests/test_compute.py—color_scale/compute.py:get_normaliser(log/lin/error),log_intervals(narrow/wide/same-decade/slim+ensure_max),compute_colour_scale(log/lin/unknown-normalisation),get_colour_values(incl. theNone→x000000sentinel).tests/test_schema_helpers.py—_style_dict(None),_fso_dict(falsy), and the null-sortby-item skip infilter_ruptures.compute.py/schema.py/ruptures.py/geojson_style_util.pynow 100%. One genuinely unreachable legacy branch inlog_intervals.slim(the sole caller passes the minimum asmax, solargest < itnever holds) is marked# pragma: no coverwith a note.96 pass / 10 skipped; ruff + mypy clean.